You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/29 10:30:20 UTC

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4995: Add parsing integrated test for `update` query SQL

tristaZero opened a new issue #4995: Add parsing integrated test for `update` query SQL
URL: https://github.com/apache/incubator-shardingsphere/issues/4995
 
 
   **Content**: Add two parsing integrated tests for `update` query SQL.
   **Difficulty rating**: ★☆☆☆☆
   
   ### How to do
   1. Add the following SQL cases to `/Users/trista/Documents/sharding-code-trista/incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/update.xml`
   
   **SQL case ID**: update_with_set_calculation
   > UPDATE t_order SET status = status - ? WHERE order_id = ? AND user_id = ?
   parameters: 1, 2, 3
   
   **SQL case ID**: update_with_where_calculation
   > UPDATE t_order SET status = status WHERE order_id = order_id - ? AND user_id = ?
   parameter: 1, 2, 3
   
   2. Calculate the parsing results of the above SQL cases and add those parsing results to `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/update.xml`
   **Tip**: You can refer to the parsing result of SQL case ID `update_without_alias` in the same directory.
   
   3. Run `SQLParserParameterizedTest` to test your SQL cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL
URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605634845
 
 
   SQL case ID: update_with_where_calculation
   > UPDATE t_order SET status = status WHERE order_id = order_id - ? AND user_id = ?
   parameter: 1, 2, 3
   
   The sql case above has three parameters, but only two placeholders. Is it right? 
   @tristaZero 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL
URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605623514
 
 
   I want to solve this issue, please assign to me!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4995: Add parsing integrated test for `update` query SQL

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4995: Add parsing integrated test for `update` query SQL
URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605615581
 
 
   Here is a good first issue for the community, welcome your join. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4995: Add parsing integrated test for `update` query SQL

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4995: Add parsing integrated test for `update` query SQL
URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605756484
 
 
   @strongduanmu Sorry, it is a typo and I fixed it. Please give it a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero closed issue #4995: Add parsing integrated test for `update` query SQL

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #4995: Add parsing integrated test for `update` query SQL
URL: https://github.com/apache/incubator-shardingsphere/issues/4995
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #4995: Add parsing integrated test for `update` query SQL
URL: https://github.com/apache/incubator-shardingsphere/issues/4995#issuecomment-605762553
 
 
   > @strongduanmu Sorry, it is a typo and I fixed it. Please give it a look.
   
   Thank you! :smile:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services