[GitHub] [beam] palmere-google commented on a change in pull request #13787: [BEAM-10114] Allow Pub/Sub Lite Sink to support increasing partitions

[GitBox <gi...@apache.org>]

palmere-google commented on a change in pull request #13787:
URL: https://github.com/apache/beam/pull/13787#discussion_r562308537



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java
##########
@@ -42,7 +43,7 @@ private Publishers() {}
       checkArgument(token.isSupertypeOf(supplied.getClass()));
       return (Publisher<PublishMetadata>) supplied;
     }
-    return RoutingPublisherBuilder.newBuilder()
+    return new PartitionCountWatchingPublisher(PartitionCountWatchingPublisherSettings.newBuilder()

Review comment:
       I don't think so. I thought maybe the java client library used it if the user configured a static set of partitions, but it doesns't seem to do so




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org