[jira] [Commented] (KAFKA-336) add an admin RPC to communicate state changes between the controller and the broker

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276377#comment-13276377 ] 

Jun Rao commented on KAFKA-336:
-------------------------------

Thanks for the patch. Some comments:

1. LeaderAndISRRequest
1.1 isInit just needs 1 byte.
1.2 remove the commented out code

2. PartitionLeaderAndISRRequest
2.1 zkVersion should be long.
2.2 how about we name the class LeaderAndISR?
2.3 remove unused imports

3. ControllerToBorkerRequestTest: remove unused imports

4. We will need a client wrapper like SimpleConsumer so that the controller can use to send the commands through RPC.

5. On the server side, we need to add a new handler in KafkaApis that can handle the new requests. We also need to create new response classes for those commands. For this jira, the server can just send a dummy response.

                
> add an admin RPC to communicate state changes between the controller and the broker
> -----------------------------------------------------------------------------------
>
>                 Key: KAFKA-336
>                 URL: https://issues.apache.org/jira/browse/KAFKA-336
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Yang Ye
>             Fix For: 0.8
>
>         Attachments: controller_broker_RPC.patch
>
>   Original Estimate: 252h
>  Remaining Estimate: 252h
>
> Based on the discussion in https://cwiki.apache.org/confluence/display/KAFKA/kafka+Detailed+Replication+Design+V3 , it's more efficient to communicate state change commands between the controller and the broker using a direct RPC than via ZK. This ticket will be implementing an admin RPC client for the controller to send state change commands.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira