[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1978: xtensa/esp32: Add power management of deep-sleep

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #1978:
URL: https://github.com/apache/incubator-nuttx/pull/1978#discussion_r503947296



##########
File path: arch/xtensa/src/esp32/esp32_pm.c
##########
@@ -180,8 +215,28 @@ static struct esp32_sleep_config_t s_config =
  * Private Functions
  ****************************************************************************/
 
+/* CPU do while loop for some time. */
+
 extern void ets_delay_us(uint32_t us);
 
+/* Set CRC of Fast RTC memory 0-0x7ff into RTC STORE7. */
+
+extern void set_rtc_memory_crc(void);
+
+/* Set the real CPU ticks per us to the ets,
+ * so that ets_delay_us will be accurate.
+ */
+
+extern void ets_update_cpu_frequency_rom(uint32_t ticks_per_us);
+
+/* Get xtal_freq value, If value not stored in RTC_STORE5, than store. */
+
+extern uint32_t ets_get_detected_xtal_freq(void);
+
+/* Get the reset reason for CPU. */
+
+extern enum esp32_reset_reason_e rtc_get_reset_reason(int cpu_no);

Review comment:
       @cwespressif is this function present in ROM?
   There is the same function here: https://github.com/apache/incubator-nuttx/blob/fff15f1b93359c17c920cd79b01b24dc1900b583/arch/xtensa/src/esp32/esp32_resetcause.h#L53
   
   Since it exists already, should that file be removed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org