You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Karsten Beyer (JIRA)" <ji...@apache.org> on 2008/06/06 18:01:50 UTC

[jira] Created: (SHINDIG-362) Improve getIncludedFeatures functionality in GadgetFeatureRegistry

Improve getIncludedFeatures functionality in GadgetFeatureRegistry
------------------------------------------------------------------

                 Key: SHINDIG-362
                 URL: https://issues.apache.org/jira/browse/SHINDIG-362
             Project: Shindig
          Issue Type: Improvement
          Components: Gadget Rendering Server (PHP)
         Environment: n/a
            Reporter: Karsten Beyer
            Priority: Trivial
         Attachments: fix-issue-SHINDIG-362.patch

renamed variables and one function to improve legibility of the code ($entry => $feature). Also build in abort mechanism to prevent the recursion addEntryToSet (now addFeatureToResults) to recurse into dependencies of already added features.

patch will be uploaded in a few minutes




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-362) Improve getIncludedFeatures functionality in GadgetFeatureRegistry

Posted by "Karsten Beyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karsten Beyer updated SHINDIG-362:
----------------------------------

    Attachment:     (was: fix-issue-SHINDIG-362.patch)

> Improve getIncludedFeatures functionality in GadgetFeatureRegistry
> ------------------------------------------------------------------
>
>                 Key: SHINDIG-362
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-362
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (PHP)
>         Environment: n/a
>            Reporter: Karsten Beyer
>            Priority: Trivial
>         Attachments: fix-issue-SHINDIG-362.patch
>
>
> renamed variables and one function to improve legibility of the code ($entry => $feature). Also build in abort mechanism to prevent the recursion addEntryToSet (now addFeatureToResults) to recurse into dependencies of already added features.
> patch will be uploaded in a few minutes

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-362) Improve getIncludedFeatures functionality in GadgetFeatureRegistry

Posted by "Karsten Beyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karsten Beyer updated SHINDIG-362:
----------------------------------

    Attachment: fix-issue-SHINDIG-362.patch

patch for issue 362

> Improve getIncludedFeatures functionality in GadgetFeatureRegistry
> ------------------------------------------------------------------
>
>                 Key: SHINDIG-362
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-362
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (PHP)
>         Environment: n/a
>            Reporter: Karsten Beyer
>            Priority: Trivial
>         Attachments: fix-issue-SHINDIG-362.patch
>
>
> renamed variables and one function to improve legibility of the code ($entry => $feature). Also build in abort mechanism to prevent the recursion addEntryToSet (now addFeatureToResults) to recurse into dependencies of already added features.
> patch will be uploaded in a few minutes

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-362) Improve getIncludedFeatures functionality in GadgetFeatureRegistry

Posted by "Karsten Beyer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karsten Beyer updated SHINDIG-362:
----------------------------------

    Attachment: fix-issue-SHINDIG-362.patch

patch for issue 362

> Improve getIncludedFeatures functionality in GadgetFeatureRegistry
> ------------------------------------------------------------------
>
>                 Key: SHINDIG-362
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-362
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (PHP)
>         Environment: n/a
>            Reporter: Karsten Beyer
>            Priority: Trivial
>         Attachments: fix-issue-SHINDIG-362.patch
>
>
> renamed variables and one function to improve legibility of the code ($entry => $feature). Also build in abort mechanism to prevent the recursion addEntryToSet (now addFeatureToResults) to recurse into dependencies of already added features.
> patch will be uploaded in a few minutes

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-362) Improve getIncludedFeatures functionality in GadgetFeatureRegistry

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-362.
----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

Looks good, commited.

Ps i don't mind if you batch up a couple of naming & constancy fixes in a single patch some times too, saves work :)

> Improve getIncludedFeatures functionality in GadgetFeatureRegistry
> ------------------------------------------------------------------
>
>                 Key: SHINDIG-362
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-362
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (PHP)
>         Environment: n/a
>            Reporter: Karsten Beyer
>            Assignee: Chris Chabot
>            Priority: Trivial
>         Attachments: fix-issue-SHINDIG-362.patch
>
>
> renamed variables and one function to improve legibility of the code ($entry => $feature). Also build in abort mechanism to prevent the recursion addEntryToSet (now addFeatureToResults) to recurse into dependencies of already added features.
> patch will be uploaded in a few minutes

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.