You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jay Zhuang (JIRA)" <ji...@apache.org> on 2017/11/27 17:40:00 UTC
[jira] [Comment Edited] (CASSANDRA-14061) trunk eclipse-warnings
[ https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267106#comment-16267106 ]
Jay Zhuang edited comment on CASSANDRA-14061 at 11/27/17 5:39 PM:
------------------------------------------------------------------
[~spodxx@gmail.com]
I'm still able to reproduce it, for example: https://circleci.com/gh/cooldoger/cassandra/148#tests/containers/0
{noformat}
eclipse-warnings:
[mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
[echo] Running Eclipse Code Analysis. Output logged to /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
[java] ----------
[java] 1. ERROR in /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java (at line 59)
[java] return new SSTableIdentityIterator(sstable, key, partitionLevelDeletion, file.getPath(), iterator);
[java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[java] Potential resource leak: 'iterator' may not be closed at this location
[java] ----------
[java] 2. ERROR in /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java (at line 79)
[java] return new SSTableIdentityIterator(sstable, key, partitionLevelDeletion, dfile.getPath(), iterator);
[java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[java] Potential resource leak: 'iterator' may not be closed at this location
[java] ----------
[java] 2 problems (2 errors)
{noformat}
And the last trunk has the same problem: https://circleci.com/gh/cooldoger/cassandra/149#queue-placeholder/containers/0
It won't fail the build, so I would suggest to make {{ant eclipse-warnings}} required in the build.
was (Author: jay.zhuang):
[~spodxx@gmail.com]
I'm still able to reproduce it, for example: https://circleci.com/gh/cooldoger/cassandra/148#tests/containers/0
{noformat}
eclipse-warnings:
[mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
[echo] Running Eclipse Code Analysis. Output logged to /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
[java] ----------
[java] 1. ERROR in /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java (at line 59)
[java] return new SSTableIdentityIterator(sstable, key, partitionLevelDeletion, file.getPath(), iterator);
[java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[java] Potential resource leak: 'iterator' may not be closed at this location
[java] ----------
[java] 2. ERROR in /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java (at line 79)
[java] return new SSTableIdentityIterator(sstable, key, partitionLevelDeletion, dfile.getPath(), iterator);
[java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[java] Potential resource leak: 'iterator' may not be closed at this location
[java] ----------
[java] 2 problems (2 errors)
{noformat}
> trunk eclipse-warnings
> ----------------------
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
> Reporter: Jay Zhuang
> Assignee: Jay Zhuang
> Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] ----------
> [java] 1. ERROR in /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key, partitionLevelDeletion, file.getPath(), iterator);
> [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [java] Potential resource leak: 'iterator' may not be closed at this location
> [java] ----------
> [java] 2. ERROR in /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key, partitionLevelDeletion, dfile.getPath(), iterator);
> [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [java] Potential resource leak: 'iterator' may not be closed at this location
> [java] ----------
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org