[GitHub] [netbeans] sdedic commented on a change in pull request #2767: Broken project auto-resolution repeats actions

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #2767:
URL: https://github.com/apache/netbeans/pull/2767#discussion_r579206765



##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/NotifyDescriptorAdapter.java
##########
@@ -222,6 +222,11 @@ private void mapDescriptorOptions() {
                 text = mapDescriptorOption(o);
             }
             if (text != null) {
+                // Discard ampersands, LSP spec does not support such pattern.
+                int mn = Mnemonics.findMnemonicAmpersand(text);

Review comment:
       `cutAmpersand` is better (handles japanese locale). Thanks ! Fixed in 17ddace




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists