You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ki...@apache.org on 2019/02/03 17:43:04 UTC

[incubator-pinot] branch master updated: fix BitmapInvertedIndexTest on Windows (#3786)

This is an automated email from the ASF dual-hosted git repository.

kishoreg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 4937e15  fix BitmapInvertedIndexTest on Windows (#3786)
4937e15 is described below

commit 4937e154133f30da50dbbccdb7237f140f94a54e
Author: Xue Yu <27...@qq.com>
AuthorDate: Mon Feb 4 01:42:56 2019 +0800

    fix BitmapInvertedIndexTest on Windows (#3786)
---
 .../segment/index/converter/SegmentV1V2ToV3FormatConverter.java    | 7 +++++--
 .../apache/pinot/segments/v1/creator/BitmapInvertedIndexTest.java  | 4 +++-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/pinot-core/src/main/java/org/apache/pinot/core/segment/index/converter/SegmentV1V2ToV3FormatConverter.java b/pinot-core/src/main/java/org/apache/pinot/core/segment/index/converter/SegmentV1V2ToV3FormatConverter.java
index e3ed72a..658cbd5 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/segment/index/converter/SegmentV1V2ToV3FormatConverter.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/segment/index/converter/SegmentV1V2ToV3FormatConverter.java
@@ -119,8 +119,11 @@ public class SegmentV1V2ToV3FormatConverter implements SegmentFormatConverter {
         .of(PosixFilePermission.OWNER_READ, PosixFilePermission.OWNER_WRITE, PosixFilePermission.OWNER_EXECUTE,
             PosixFilePermission.GROUP_READ, PosixFilePermission.GROUP_WRITE, PosixFilePermission.GROUP_EXECUTE,
             PosixFilePermission.OTHERS_READ, PosixFilePermission.OTHERS_EXECUTE);
-
-    Files.setPosixFilePermissions(v3Directory.toPath(), permissions);
+    try {
+      Files.setPosixFilePermissions(v3Directory.toPath(), permissions);
+    } catch(UnsupportedOperationException ex) {
+      LOGGER.error("unsupported non-posix filesystem permissions setting");
+    }
   }
 
   private void copyIndexData(File v2Directory, SegmentMetadataImpl v2Metadata, File v3Directory)
diff --git a/pinot-core/src/test/java/org/apache/pinot/segments/v1/creator/BitmapInvertedIndexTest.java b/pinot-core/src/test/java/org/apache/pinot/segments/v1/creator/BitmapInvertedIndexTest.java
index 914eac4..16816b9 100644
--- a/pinot-core/src/test/java/org/apache/pinot/segments/v1/creator/BitmapInvertedIndexTest.java
+++ b/pinot-core/src/test/java/org/apache/pinot/segments/v1/creator/BitmapInvertedIndexTest.java
@@ -20,6 +20,7 @@ package org.apache.pinot.segments.v1.creator;
 
 import java.io.File;
 import java.io.FileInputStream;
+import java.net.URI;
 import java.net.URL;
 import java.util.HashSet;
 import java.util.Set;
@@ -67,7 +68,8 @@ public class BitmapInvertedIndexTest {
     FileUtils.deleteQuietly(INDEX_DIR);
     URL resourceUrl = getClass().getClassLoader().getResource(AVRO_FILE_PATH);
     Assert.assertNotNull(resourceUrl);
-    _avroFile = new File(resourceUrl.getFile());
+    URI resourceUri = new URI(resourceUrl.toString());
+    _avroFile = new File(resourceUri);
 
     SegmentGeneratorConfig segmentGeneratorConfig =
         SegmentTestUtils.getSegmentGeneratorConfigWithoutTimeColumn(_avroFile, INDEX_DIR, "myTable");


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org