You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/09 13:32:48 UTC

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #11635: [Hexagon] Tighten requirements on inclusion of runtime sources

kparzysz-quic commented on code in PR #11635:
URL: https://github.com/apache/tvm/pull/11635#discussion_r893511615


##########
cmake/modules/Hexagon.cmake:
##########
@@ -116,7 +116,7 @@ function(add_hexagon_wrapper_paths)
   link_directories("${HEXAGON_TOOLCHAIN}/lib/iss")
 endfunction()
 
-if(BUILD_FOR_HEXAGON OR USE_HEXAGON_RPC)
+if(BUILD_FOR_HEXAGON OR ("${USE_HEXAGON_RPC}" STREQUAL "HEXAGON"))

Review Comment:
   When would `BUILD_FOR_HEXAGON` be false, but `USE_HEXAGON_RPC` be `"HEXAGON"`?  It seems like the latter implies the former...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org