You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Si Chen (JIRA)" <ji...@apache.org> on 2006/11/02 18:47:19 UTC

[jira] Closed: (OFBIZ-399) Invoice actual shipping charges

     [ http://issues.apache.org/jira/browse/OFBIZ-399?page=all ]

Si Chen closed OFBIZ-399.
-------------------------

    Resolution: Fixed

This is taken care of in SVN r 4699995, 470162, 470165, 470168, 470170, 470173.  Here's a recap:

- Added Shipment.additionalShippingCharge field (currency-amount)
- Added ProductStore.prorateTaxes field (indicator)
- Added demo data for ProductStore.prorateTaxes ("Y") to Ecommerce and POS data
- Added OrderAdjustment.originalAdjustmentId (id) and relation to OrderAdjustment
- Added OrderAdjustmentBilling entity
- Added additionalShippingCharge field to ShipmentForms.editShipment
- Added createOrderAdjustmentBilling service to OrderSimpleMethods
- Added calculateInvoicedAdjustmentTotal service to InvoiceServices as a helper service to determine amount of a given OrderAdjustment billed to existing invoices
- Modified InvoiceServices:
     * createInvoicesFromShipments()
           o If shipping charges should not be prorated, examine the order shipments for additional shipping charges
           o For each additional shipping charge:
                 + Create an OrderAdjustment
                 + Calculate taxes on the additional charge, if any, and create another OrderAdjustment
                 + If part of the order was paid via credit card, create an OrderPaymentPreference for the additional charges and authorize it
     * createInvoiceForOrder()
           o When creating invoice items from OrderAdjustments (item- or header- level), call new service calculateInvoicedAdjustmentTotal to discover how much of the adjustment to invoice. Skip the adjustment if it has been fully invoiced
           o Create OrderAdjustmentBilling records for every OrderAdjustment amount added as an InvoiceItem
           o Prorate order-level taxes in the same manner as shipping charges, controlled by the ProductStore.prorateTaxes field

Notes:

- Shipment.additionalShippingCharge will be ignored when creating an invoice from a Shipment if ProductStore.prorateShipping == "Y"
- Fixed a bug in Opentaps 0.8 PaymentGatewayServices where authorizing an OrderPaymentPreference always authorized the remaining amount of the order and ignored the requested overrideAmount
- The current assumption is that there is no distinction between sales tax and shipping tax - IE that the shipping tax rate for a given origin/destination combination is identical to the sales tax for that combination
- When authorizing Shipment.additionalShippingCharge when the Shipment is related to an order which has multiple credit card OrderPaymentPreferences, the first card found will be used
- If the authorization for additionalShippingCharge fails, the shipment will still be completed



> Invoice actual shipping charges
> -------------------------------
>
>                 Key: OFBIZ-399
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-399
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: product
>            Reporter: Si Chen
>
> The idea is to invoice actual shipping charges as they are incurred on invoices, rather than just relying on the original order shipping charges and pro-rating them across orders.  This is more of a common practice among manufacturing/distribution companies.
> The way that it will work is:
> 1.  Add a field for "additional shipping charge" to Shipment
> 2.  When the shipment is invoiced, the additional shipping charge will be added to the order and the invoice for the shipment.
> 3.  A tax will be calculated on this shipping charge.
> 4.  The additional amount of tax + shipping charge would be authorized again on the order.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira