You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Akhil S Naik <as...@hortonworks.com> on 2018/01/02 10:26:18 UTC
Review Request 64884: AMBARI-22711 -- Ambari Versions Page is having
JS error When using redhat satellite server for repos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64884/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.
Bugs: https://issues.apache.org/jira/browse/AMBARI-22711
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-22711
Repository: ambari
Description
-------
Ambari Versions page not updating when using Redhat satellite server for repos
Due to exception in JS Code
as a Fix :
in stack_mapper.js code
for the line : stack.use_redhat_satellite = Em.get(item,'operating_systems.0.OperatingSystems.ambari_managed_repositories') === false;
we need to remove the direct check of property and use the Em.get Instead (Ember-metal APIhttps://github.com/emberjs/ember.js/blob/0d68d0a3b3072995e3db603a24fe5ac56cf26d6d/packages/ember-metal/lib/property_get.js)
Diffs
-----
ambari-web/app/mappers/stack_mapper.js 323a033
Diff: https://reviews.apache.org/r/64884/diff/1/
Testing
-------
* unit tests runs fine
* fix works fine
*
Thanks,
Akhil S Naik
Re: Review Request 64884: AMBARI-22711 -- Ambari Versions Page is
having JS error When using redhat satellite server for repos
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64884/#review194622
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Янв. 2, 2018, 10:26 д.п., Akhil S Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64884/
> -----------------------------------------------------------
>
> (Updated Янв. 2, 2018, 10:26 д.п.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-22711
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-22711
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari Versions page not updating when using Redhat satellite server for repos
> Due to exception in JS Code
>
> as a Fix :
> in stack_mapper.js code
> for the line : stack.use_redhat_satellite = Em.get(item,'operating_systems.0.OperatingSystems.ambari_managed_repositories') === false;
>
> we need to remove the direct check of property and use the Em.get Instead (Ember-metal APIhttps://github.com/emberjs/ember.js/blob/0d68d0a3b3072995e3db603a24fe5ac56cf26d6d/packages/ember-metal/lib/property_get.js)
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/stack_mapper.js 323a033
>
>
> Diff: https://reviews.apache.org/r/64884/diff/1/
>
>
> Testing
> -------
>
> * unit tests runs fine
> * fix works fine
> *
>
>
> Thanks,
>
> Akhil S Naik
>
>