[GitHub] [flink] Jiayi-Liao commented on a change in pull request #12261: [FLINK-17823][network] Resolve the race condition while releasing RemoteInputChannel

[GitBox <gi...@apache.org>]

Jiayi-Liao commented on a change in pull request #12261:
URL: https://github.com/apache/flink/pull/12261#discussion_r427749670



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -181,6 +181,14 @@ void retriggerSubpartitionRequest(int subpartitionIndex) throws IOException {
 			moreAvailable = !receivedBuffers.isEmpty();
 		}
 
+		if (next == null) {

Review comment:
       I guess it's theoretically impossible that we get a null buffer here with your changes in `releaseAllResources`, which seems to solve two cases you mentioned in description. So.. this check is just for other unknown bad cases?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org