You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/12 08:20:18 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #10297: Add type annotations for Google mlengine_operator_utils.py

ephraimbuddy commented on a change in pull request #10297:
URL: https://github.com/apache/airflow/pull/10297#discussion_r469087617



##########
File path: airflow/providers/google/cloud/utils/mlengine_operator_utils.py
##########
@@ -203,7 +210,7 @@ def validate_err_and_count(summary):
     if dag is not None and dag.default_args is not None:
         default_args = dag.default_args
         project_id = project_id or default_args.get('project_id')
-        region = region or default_args.get('region')
+        region = region or default_args['region']

Review comment:
       I would suggest `default_args.get("region", None)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org