You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/15 01:08:39 UTC

[GitHub] [pulsar-client-go] hantmac commented on a diff in pull request #734: [Issue 718] Fix nil pointer dereference in TopicNameWithoutPartitionPart

hantmac commented on code in PR #734:
URL: https://github.com/apache/pulsar-client-go/pull/734#discussion_r850954145


##########
pulsar/internal/topic_name.go:
##########
@@ -107,6 +107,9 @@ func ParseTopicName(topic string) (*TopicName, error) {
 }
 
 func TopicNameWithoutPartitionPart(tn *TopicName) string {
+	if tn == nil {
+		return ""
+	}

Review Comment:
   Checking both looks good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org