You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2015/06/08 20:52:05 UTC
spark git commit: [SQL][minor] remove duplicated cases in
`DecimalPrecision`
Repository: spark
Updated Branches:
refs/heads/master bbdfc0a40 -> fe7669d30
[SQL][minor] remove duplicated cases in `DecimalPrecision`
We already have a rule to do type coercion for fixed decimal and unlimited decimal in `WidenTypes`, so we don't need to handle them in `DecimalPrecision`.
Author: Wenchen Fan <cl...@outlook.com>
Closes #6698 from cloud-fan/fix and squashes the following commits:
413ad4a [Wenchen Fan] remove duplicated cases
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/fe7669d3
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/fe7669d3
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/fe7669d3
Branch: refs/heads/master
Commit: fe7669d3072b72954ad0c3f2f8846a0fde839ead
Parents: bbdfc0a
Author: Wenchen Fan <cl...@outlook.com>
Authored: Mon Jun 8 11:52:02 2015 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Mon Jun 8 11:52:02 2015 -0700
----------------------------------------------------------------------
.../apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala | 6 ------
1 file changed, 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/fe7669d3/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
index a42ffce..737905c 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
@@ -445,12 +445,6 @@ trait HiveTypeCoercion {
e2 @ DecimalType.Expression(p2, s2)) if p1 != p2 || s1 != s2 =>
val resultType = DecimalType(max(p1, p2), max(s1, s2))
b.makeCopy(Array(Cast(e1, resultType), Cast(e2, resultType)))
- case b @ BinaryComparison(e1 @ DecimalType.Fixed(_, _), e2)
- if e2.dataType == DecimalType.Unlimited =>
- b.makeCopy(Array(Cast(e1, DecimalType.Unlimited), e2))
- case b @ BinaryComparison(e1, e2 @ DecimalType.Fixed(_, _))
- if e1.dataType == DecimalType.Unlimited =>
- b.makeCopy(Array(e1, Cast(e2, DecimalType.Unlimited)))
// Promote integers inside a binary expression with fixed-precision decimals to decimals,
// and fixed-precision decimals in an expression with floats / doubles to doubles
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org