You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2016/09/16 20:15:44 UTC
svn commit: r1761076 - /ofbiz/trunk/build.gradle
Author: jleroux
Date: Fri Sep 16 20:15:43 2016
New Revision: 1761076
URL: http://svn.apache.org/viewvc?rev=1761076&view=rev
Log:
Documents: adds a small commented out snippet in build.gradle for when Xlint:unchecked and -Xlint:deprecation are needed
Modified:
ofbiz/trunk/build.gradle
Modified: ofbiz/trunk/build.gradle
URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.gradle?rev=1761076&r1=1761075&r2=1761076&view=diff
==============================================================================
--- ofbiz/trunk/build.gradle (original)
+++ ofbiz/trunk/build.gradle Fri Sep 16 20:15:43 2016
@@ -39,6 +39,16 @@ javadoc.failOnError = false
sourceCompatibility = '1.8'
targetCompatibility = '1.8'
+/* Please don't remove. This is useful when you want to see
+ unchecked warnings and deprecated members or classes in log.
+allprojects {
+ gradle.projectsEvaluated {
+ tasks.withType(JavaCompile) {
+ options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation"
+ }
+ }
+}*/
+
// Enforces UTF-8 java compilation encoding on Windows platform
tasks.withType(JavaCompile) {
options.encoding = 'UTF-8'
@@ -814,10 +824,10 @@ task gitInfoFooter(group: committerGroup
revision = revisionOutput.toString()
gitFooterFile.delete()
gitFooterFile.createNewFile()
- gitFooterFile << "Branch: ${branch}"
- gitFooterFile << "Revision: ${revision}"
- gitFooterFile << "Built on: ${timestamp}" + System.lineSeparator()
- gitFooterFile << "Java Version: ${org.gradle.internal.jvm.Jvm.current()}"
+ gitFooterFile << '${uiLabelMap.Branch} : ' + "${branch}" + System.lineSeparator()
+ gitFooterFile << '${uiLabelMap.Revision} : ' + "${revision}" + System.lineSeparator()
+ gitFooterFile << '${uiLabelMap.BuiltOn} : ' + "${timestamp}" + System.lineSeparator()
+ gitFooterFile << '${uiLabelMap.JavaVersion} : ' + "${org.gradle.internal.jvm.Jvm.current()}"
}
task svnInfoFooter(group: committerGroup, description: 'Update the Subversion revision info in the footer if Subversion is used') << {
@@ -838,10 +848,10 @@ task svnInfoFooter(group: committerGroup
def info = new XmlParser().parseText(svnOutput.toString())
svnFooterFile.delete()
svnFooterFile.createNewFile()
- svnFooterFile << "Branch: ${info.entry.url.text()}" + System.lineSeparator()
- svnFooterFile << "Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
- svnFooterFile << "Built on: ${timestamp}" + System.lineSeparator()
- svnFooterFile << "Java Version: ${org.gradle.internal.jvm.Jvm.current()}"
+ svnFooterFile << '${uiLabelMap.Branch} : ' + "${info.entry.url.text()}" + System.lineSeparator()
+ svnFooterFile << '${uiLabelMap.Revision} : ' + "${info.entry.commit.@revision}" + System.lineSeparator()
+ svnFooterFile << '${uiLabelMap.BuiltOn} : ' + "${timestamp}" + System.lineSeparator()
+ svnFooterFile << '${uiLabelMap.JavaVersion} : ' + "${org.gradle.internal.jvm.Jvm.current()}"
}
// ========== hidden support tasks ==========
Re: svn commit: r1761076 - /ofbiz/trunk/build.gradle
Posted by Jacques Le Roux <ja...@les7arts.com>.
Ah yes good idea, old Ant reflex, I will
Jacques
Le 16/09/2016 � 22:23, Taher Alkhateeb a �crit :
> Jacques .. I think it is bad practice to put commented out code. If this is
> really necessary we can put a task for it if needed.
>
> On Fri, Sep 16, 2016 at 11:15 PM, <jl...@apache.org> wrote:
>
>> Author: jleroux
>> Date: Fri Sep 16 20:15:43 2016
>> New Revision: 1761076
>>
>> URL: http://svn.apache.org/viewvc?rev=1761076&view=rev
>> Log:
>> Documents: adds a small commented out snippet in build.gradle for when
>> Xlint:unchecked and -Xlint:deprecation are needed
>>
>>
>> Modified:
>> ofbiz/trunk/build.gradle
>>
>> Modified: ofbiz/trunk/build.gradle
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.gradle?rev=
>> 1761076&r1=1761075&r2=1761076&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/trunk/build.gradle (original)
>> +++ ofbiz/trunk/build.gradle Fri Sep 16 20:15:43 2016
>> @@ -39,6 +39,16 @@ javadoc.failOnError = false
>> sourceCompatibility = '1.8'
>> targetCompatibility = '1.8'
>>
>> +/* Please don't remove. This is useful when you want to see
>> + unchecked warnings and deprecated members or classes in log.
>> +allprojects {
>> + gradle.projectsEvaluated {
>> + tasks.withType(JavaCompile) {
>> + options.compilerArgs << "-Xlint:unchecked" <<
>> "-Xlint:deprecation"
>> + }
>> + }
>> +}*/
>> +
>> // Enforces UTF-8 java compilation encoding on Windows platform
>> tasks.withType(JavaCompile) {
>> options.encoding = 'UTF-8'
>> @@ -814,10 +824,10 @@ task gitInfoFooter(group: committerGroup
>> revision = revisionOutput.toString()
>> gitFooterFile.delete()
>> gitFooterFile.createNewFile()
>> - gitFooterFile << "Branch: ${branch}"
>> - gitFooterFile << "Revision: ${revision}"
>> - gitFooterFile << "Built on: ${timestamp}" + System.lineSeparator()
>> - gitFooterFile << "Java Version: ${org.gradle.internal.jvm.Jvm.
>> current()}"
>> + gitFooterFile << '${uiLabelMap.Branch} : ' + "${branch}" +
>> System.lineSeparator()
>> + gitFooterFile << '${uiLabelMap.Revision} : ' + "${revision}" +
>> System.lineSeparator()
>> + gitFooterFile << '${uiLabelMap.BuiltOn} : ' + "${timestamp}" +
>> System.lineSeparator()
>> + gitFooterFile << '${uiLabelMap.JavaVersion} : ' +
>> "${org.gradle.internal.jvm.Jvm.current()}"
>> }
>>
>> task svnInfoFooter(group: committerGroup, description: 'Update the
>> Subversion revision info in the footer if Subversion is used') << {
>> @@ -838,10 +848,10 @@ task svnInfoFooter(group: committerGroup
>> def info = new XmlParser().parseText(svnOutput.toString())
>> svnFooterFile.delete()
>> svnFooterFile.createNewFile()
>> - svnFooterFile << "Branch: ${info.entry.url.text()}" +
>> System.lineSeparator()
>> - svnFooterFile << "Revision: ${info.entry.commit.@revision}" +
>> System.lineSeparator()
>> - svnFooterFile << "Built on: ${timestamp}" + System.lineSeparator()
>> - svnFooterFile << "Java Version: ${org.gradle.internal.jvm.Jvm.
>> current()}"
>> + svnFooterFile << '${uiLabelMap.Branch} : ' +
>> "${info.entry.url.text()}" + System.lineSeparator()
>> + svnFooterFile << '${uiLabelMap.Revision} : ' +
>> "${info.entry.commit.@revision}" + System.lineSeparator()
>> + svnFooterFile << '${uiLabelMap.BuiltOn} : ' + "${timestamp}" +
>> System.lineSeparator()
>> + svnFooterFile << '${uiLabelMap.JavaVersion} : ' +
>> "${org.gradle.internal.jvm.Jvm.current()}"
>> }
>>
>> // ========== hidden support tasks ==========
>>
>>
>>
Re: svn commit: r1761076 - /ofbiz/trunk/build.gradle
Posted by Taher Alkhateeb <sl...@gmail.com>.
Jacques .. I think it is bad practice to put commented out code. If this is
really necessary we can put a task for it if needed.
On Fri, Sep 16, 2016 at 11:15 PM, <jl...@apache.org> wrote:
> Author: jleroux
> Date: Fri Sep 16 20:15:43 2016
> New Revision: 1761076
>
> URL: http://svn.apache.org/viewvc?rev=1761076&view=rev
> Log:
> Documents: adds a small commented out snippet in build.gradle for when
> Xlint:unchecked and -Xlint:deprecation are needed
>
>
> Modified:
> ofbiz/trunk/build.gradle
>
> Modified: ofbiz/trunk/build.gradle
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.gradle?rev=
> 1761076&r1=1761075&r2=1761076&view=diff
> ============================================================
> ==================
> --- ofbiz/trunk/build.gradle (original)
> +++ ofbiz/trunk/build.gradle Fri Sep 16 20:15:43 2016
> @@ -39,6 +39,16 @@ javadoc.failOnError = false
> sourceCompatibility = '1.8'
> targetCompatibility = '1.8'
>
> +/* Please don't remove. This is useful when you want to see
> + unchecked warnings and deprecated members or classes in log.
> +allprojects {
> + gradle.projectsEvaluated {
> + tasks.withType(JavaCompile) {
> + options.compilerArgs << "-Xlint:unchecked" <<
> "-Xlint:deprecation"
> + }
> + }
> +}*/
> +
> // Enforces UTF-8 java compilation encoding on Windows platform
> tasks.withType(JavaCompile) {
> options.encoding = 'UTF-8'
> @@ -814,10 +824,10 @@ task gitInfoFooter(group: committerGroup
> revision = revisionOutput.toString()
> gitFooterFile.delete()
> gitFooterFile.createNewFile()
> - gitFooterFile << "Branch: ${branch}"
> - gitFooterFile << "Revision: ${revision}"
> - gitFooterFile << "Built on: ${timestamp}" + System.lineSeparator()
> - gitFooterFile << "Java Version: ${org.gradle.internal.jvm.Jvm.
> current()}"
> + gitFooterFile << '${uiLabelMap.Branch} : ' + "${branch}" +
> System.lineSeparator()
> + gitFooterFile << '${uiLabelMap.Revision} : ' + "${revision}" +
> System.lineSeparator()
> + gitFooterFile << '${uiLabelMap.BuiltOn} : ' + "${timestamp}" +
> System.lineSeparator()
> + gitFooterFile << '${uiLabelMap.JavaVersion} : ' +
> "${org.gradle.internal.jvm.Jvm.current()}"
> }
>
> task svnInfoFooter(group: committerGroup, description: 'Update the
> Subversion revision info in the footer if Subversion is used') << {
> @@ -838,10 +848,10 @@ task svnInfoFooter(group: committerGroup
> def info = new XmlParser().parseText(svnOutput.toString())
> svnFooterFile.delete()
> svnFooterFile.createNewFile()
> - svnFooterFile << "Branch: ${info.entry.url.text()}" +
> System.lineSeparator()
> - svnFooterFile << "Revision: ${info.entry.commit.@revision}" +
> System.lineSeparator()
> - svnFooterFile << "Built on: ${timestamp}" + System.lineSeparator()
> - svnFooterFile << "Java Version: ${org.gradle.internal.jvm.Jvm.
> current()}"
> + svnFooterFile << '${uiLabelMap.Branch} : ' +
> "${info.entry.url.text()}" + System.lineSeparator()
> + svnFooterFile << '${uiLabelMap.Revision} : ' +
> "${info.entry.commit.@revision}" + System.lineSeparator()
> + svnFooterFile << '${uiLabelMap.BuiltOn} : ' + "${timestamp}" +
> System.lineSeparator()
> + svnFooterFile << '${uiLabelMap.JavaVersion} : ' +
> "${org.gradle.internal.jvm.Jvm.current()}"
> }
>
> // ========== hidden support tasks ==========
>
>
>