You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/20 22:41:53 UTC

[GitHub] [incubator-tvm] sxjscience opened a new issue #6721: [FRONTEND][MXNET 2.0] Support three missing operators: _npi_subtract_scalar, _npi_stack, _npi_advanced_indexing_multiple

sxjscience opened a new issue #6721:
URL: https://github.com/apache/incubator-tvm/issues/6721


   Recently, TVM has supported the incoming MXNet 2.0 frontend via a series of PRs: https://github.com/apache/incubator-tvm/pull/6054, https://github.com/apache/incubator-tvm/pull/6699. This enables the new GluonNLP 1.0, which has upgraded from MXNet 1.x to MXNet 2.0 to convert to TVM graph (as added in https://github.com/dmlc/gluon-nlp/pull/1390). However, I noticed that there are three missing operators when I profile against the [BART model](https://github.com/dmlc/gluon-nlp/blob/master/src/gluonnlp/models/bart.py).
   
   - _npi_subtract_scalar
   - _npi_stack
   - _npi_advanced_indexing_multiple
   
   The first two operators are pretty straightforward to support while the `_npi_advanced_indexing_multiple` is more complicated and is triggered when we call `a[idx1, idx2]`. The MXNet-side implementation of `_npi_advanced_indexing_multiple` is here: https://github.com/apache/incubator-mxnet/blob/6bbd53107aa16fc41e8d462cf5dc46fb70d592df/src/operator/numpy/np_indexing_op.cc#L479-L491
   
   Since I do not have the bandwidth in supporting this operator. Help is really appreciated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] sxjscience commented on issue #6721: [FRONTEND][MXNET 2.0] Support three missing operators: _npi_subtract_scalar, _npi_stack, _npi_advanced_indexing_multiple

Posted by GitBox <gi...@apache.org>.
sxjscience commented on issue #6721:
URL: https://github.com/apache/incubator-tvm/issues/6721#issuecomment-713182218


   To provide more context on the `_npi_advanced_indexing_multiple` usage in GluonNLP, it's used here: https://github.com/dmlc/gluon-nlp/blob/149270a7b357e2a34972e6a596fbeea2bbd6869e/src/gluonnlp/models/bart.py#L277


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] sxjscience commented on issue #6721: [FRONTEND][MXNET 2.0] Support three missing operators: _npi_subtract_scalar, _npi_stack, _npi_advanced_indexing_multiple

Posted by GitBox <gi...@apache.org>.
sxjscience commented on issue #6721:
URL: https://github.com/apache/incubator-tvm/issues/6721#issuecomment-713181491


   Also cc @yzhliu


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org