You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by mitchell852 <gi...@git.apache.org> on 2017/01/11 23:24:39 UTC
[GitHub] incubator-trafficcontrol pull request #181: [TC-96] - adds group_by to dbix ...
GitHub user mitchell852 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/181
[TC-96] - adds group_by to dbix query to satisfy postgres
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mitchell852/incubator-trafficcontrol tc-96
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit bb6d23644e5944a5572e781c739e811714edae46
Author: Jeremy Mitchell <mi...@gmail.com>
Date: 2017-01-11T23:22:54Z
adds group_by to dbix query
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #181: [TC-96] - adds group_by to dbix ...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/181#discussion_r96448937
--- Diff: traffic_ops/app/lib/API/Cdn.pm ---
@@ -264,7 +264,8 @@ sub get_traffic_monitor_config {
{ 'cdn.name' => $cdn_name },
{ prefetch => ['cdn', 'profile', 'type'],
select => 'me.profile',
- distinct => 1
+ distinct => 1,
--- End diff --
talk to @elsloo :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #181: [TC-96] - adds group_by to dbix ...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/181#discussion_r96442726
--- Diff: traffic_ops/app/lib/API/Cdn.pm ---
@@ -264,7 +264,8 @@ sub get_traffic_monitor_config {
{ 'cdn.name' => $cdn_name },
{ prefetch => ['cdn', 'profile', 'type'],
select => 'me.profile',
- distinct => 1
+ distinct => 1,
--- End diff --
didn't add the distinct. i just added a comma :) i think....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #181: [TC-96] - adds group_by to dbix ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/181#discussion_r96469757
--- Diff: traffic_ops/app/lib/API/Cdn.pm ---
@@ -264,7 +264,8 @@ sub get_traffic_monitor_config {
{ 'cdn.name' => $cdn_name },
{ prefetch => ['cdn', 'profile', 'type'],
select => 'me.profile',
- distinct => 1
+ distinct => 1,
--- End diff --
I know you didn't add it, just commenting. My patch would involve removing DBIx. @mitchell852 knows what I am referring to. We went through a handful of slow queries that were all slow because `DISTINCT` was added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #181: [TC-96] - adds group_by to dbix ...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/181#discussion_r96442294
--- Diff: traffic_ops/app/lib/API/Cdn.pm ---
@@ -264,7 +264,8 @@ sub get_traffic_monitor_config {
{ 'cdn.name' => $cdn_name },
{ prefetch => ['cdn', 'profile', 'type'],
select => 'me.profile',
- distinct => 1
+ distinct => 1,
--- End diff --
patches are welcome :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #181: [TC-96] - adds group_by to dbix ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/181#discussion_r96341728
--- Diff: traffic_ops/app/lib/API/Cdn.pm ---
@@ -264,7 +264,8 @@ sub get_traffic_monitor_config {
{ 'cdn.name' => $cdn_name },
{ prefetch => ['cdn', 'profile', 'type'],
select => 'me.profile',
- distinct => 1
+ distinct => 1,
--- End diff --
All this distinct business makes me \U0001f61e .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #181: [TC-96] - adds group_by to dbix ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---