You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/11/20 02:02:04 UTC
[GitHub] [incubator-livy] runzhiwang opened a new pull request #259:
[LIVY-714] Fix cannot remove the app in leakedAppTags when timeout
runzhiwang opened a new pull request #259: [LIVY-714] Fix cannot remove the app in leakedAppTags when timeout
URL: https://github.com/apache/incubator-livy/pull/259
## What changes were proposed in this pull request?
1.`var isRemoved = false` should be in `while(iter.hasNext),` otherwise if there are two apps, the first app will be killApplication and the second app will timeout in this loop, and after remove the first app,` isRemoved = true`, and the second app cannot pass the` if(!isRemoved)` and only will be deleted in the next loop.
2.`entry.getValue - now` is negative, and never greater than `sessionLeakageCheckTimeout`.
## How was this patch tested?
Existed IT and UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services