You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/11/28 00:58:05 UTC
[GitHub] [fineract] vidakovic opened a new pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
vidakovic opened a new pull request #1986:
URL: https://github.com/apache/fineract/pull/1986
## Description
- proper Docker image build with reasonable startup parameters (the ones that were in place until now were not really great)
- using the latest JDK 17 LTS release everywhere (Docker image and workflows)
- Travis builds were failing, some regressions fell through the cracks (the biggest: GSON serializer was missing an adapter; without it was crashing with security exceptions as reflection is not generally allowed anymore); see: "org.apache.fineract.infrastructure.core.serialization.GoogleGsonSerializerHelper"
- moved the WAR build into a separate module; it's really unnecessarily hard to make everything work in one build script without making it overly complex; main reason for move: Jib (the Docker build module) detects if a project is of type WAR and starts to do all kind of automatic WAR related configuration; the WAR stuff is not our main deliverable; maybe we can drop it in the future; anyway... still there, just different directory
- I've made some small adjustments in the docker-compose.yml file; this thing is not used anymore for building the Docker images (with this change Dockerfile, entrypoint.sh and .dockerignore also disappeared)
- the integration tests run now with Docker Compose instead of Cargo; no more brittle Mysql configuration and startup; this will run no matter the OS or the environment; now there is only one mechanism that handles everything (via a Docker Compose Gradle plugin)
- with the move to JDK 17 the Travis builds were not working anymore; the main reason was missing JVM arguments in the gradle.properties to make the Gradle Spotless plugin properly work
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757833593
##########
File path: fineract-provider/build.gradle
##########
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
- enabled = false
+jib {
+ from {
+ // image = 'azul/zulu-openjdk-alpine:17-jre' // once we get rid of OpenJPA we could reduce space significantly
+ image = 'azul/zulu-openjdk-alpine:17'
+ }
+
+ to {
+ image = 'fineract'
+ tags = [
+ "${releaseVersion}",
+ 'latest'
+ ]
+ }
+
+ container {
+ creationTime = 'USE_CURRENT_TIMESTAMP'
+ jvmFlags = [
+ '-Duser.home=/data',
+ '-Xmx1G',
+ '-Xms1G',
+ '-XshowSettings:vm',
+ '-XX:+UseContainerSupport',
+ '-XX:+UseStringDeduplication',
+ '-XX:MinRAMPercentage=25',
+ '-XX:MaxRAMPercentage=80'
+ ]
+ args = [
+ '-Dspring.profiles.active=basicauth',
+ '-Dfile.encoding=UTF-8',
+ '-Duser.timezone=UTC',
Review comment:
Well... we should override such test specific settings in the Docker Compose file now... UTC as a default makes sense I think... users need to override this one anyway in prod.
In terms of unit tests: I think less than a handful depend on the timezone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
ptuomola commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757832128
##########
File path: .travis.yml
##########
@@ -57,13 +48,8 @@ install:
- curl -O https://cdn.azul.com/zulu/bin/zulu-repo_1.0.0-3_all.deb
- sudo apt-get -yq install ./zulu-repo_1.0.0-3_all.deb
- sudo apt-get -q update
- - sudo apt-get -yq install zulu17-jdk
- - export JAVA_HOME=/usr/lib/jvm/zulu17
- - echo "USE mysql;\nALTER USER 'root'@'localhost' IDENTIFIED BY 'mysql';\n" | mysql -u root
- - mysql -u root -pmysql -e 'CREATE DATABASE IF NOT EXISTS `fineract_tenants`;'
- - mysql -u root -pmysql -e 'CREATE DATABASE IF NOT EXISTS `fineract_default`;'
-# Hardcoding the time zone is a temporary fix for https://issues.apache.org/jira/browse/FINERACT-723
- - export TZ=Asia/Kolkata
+ - sudo apt-get -yq install zulu11-jdk
+ - export JAVA_HOME=/usr/lib/jvm/zulu11
Review comment:
This looks like it's still pointing to JDK 11?
##########
File path: fineract-provider/build.gradle
##########
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
- enabled = false
+jib {
+ from {
+ // image = 'azul/zulu-openjdk-alpine:17-jre' // once we get rid of OpenJPA we could reduce space significantly
+ image = 'azul/zulu-openjdk-alpine:17'
+ }
+
+ to {
+ image = 'fineract'
+ tags = [
+ "${releaseVersion}",
+ 'latest'
+ ]
+ }
+
+ container {
+ creationTime = 'USE_CURRENT_TIMESTAMP'
+ jvmFlags = [
+ '-Duser.home=/data',
+ '-Xmx1G',
+ '-Xms1G',
+ '-XshowSettings:vm',
+ '-XX:+UseContainerSupport',
+ '-XX:+UseStringDeduplication',
+ '-XX:MinRAMPercentage=25',
+ '-XX:MaxRAMPercentage=80'
+ ]
+ args = [
+ '-Dspring.profiles.active=basicauth',
Review comment:
Could we make this env parameter for the image, but default to basicauth? That way we could use the same image for all the different profiles (twofactor, oauth etc) and also run tests for each of them?
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java
##########
@@ -45,6 +48,12 @@
private static final String LOAN_PRODUCT_SHORT_NAME = "loanProductShortName";
private static final String SAVINGS_PRODUCT_SHORT_NAME = "savingsProductShortName";
private static final String SHARE_PRODUCT_SHORT_NAME = "sharesProductShortName";
+ private final ConfigurationReadPlatformService configurationReadPlatformService;
+
+ @Autowired
+ public AccountNumberGenerator(final ConfigurationReadPlatformService configurationReadPlatformService) {
+ this.configurationReadPlatformService = configurationReadPlatformService;
+ }
Review comment:
I think these changes are from another PR that was already merged? Can you rebase your PR to develop?
##########
File path: fineract-provider/build.gradle
##########
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
- enabled = false
+jib {
+ from {
+ // image = 'azul/zulu-openjdk-alpine:17-jre' // once we get rid of OpenJPA we could reduce space significantly
+ image = 'azul/zulu-openjdk-alpine:17'
+ }
+
+ to {
+ image = 'fineract'
+ tags = [
+ "${releaseVersion}",
+ 'latest'
+ ]
+ }
+
+ container {
+ creationTime = 'USE_CURRENT_TIMESTAMP'
+ jvmFlags = [
+ '-Duser.home=/data',
+ '-Xmx1G',
+ '-Xms1G',
+ '-XshowSettings:vm',
+ '-XX:+UseContainerSupport',
+ '-XX:+UseStringDeduplication',
+ '-XX:MinRAMPercentage=25',
+ '-XX:MaxRAMPercentage=80'
+ ]
+ args = [
+ '-Dspring.profiles.active=basicauth',
+ '-Dfile.encoding=UTF-8',
+ '-Duser.timezone=UTC',
Review comment:
At least previously the integration tests required timezone Asia/Kalkuta to pass... does this work?
##########
File path: fineract-provider/build.gradle
##########
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
contents {
from bootJar
- from war
Review comment:
Out of interest, does the distribution task actually work for you? I was yesterday working on another PR (automate updating of all the dependent licenses into the distribution) but could not get distTar etc to do anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757833279
##########
File path: .travis.yml
##########
@@ -57,13 +48,8 @@ install:
- curl -O https://cdn.azul.com/zulu/bin/zulu-repo_1.0.0-3_all.deb
- sudo apt-get -yq install ./zulu-repo_1.0.0-3_all.deb
- sudo apt-get -q update
- - sudo apt-get -yq install zulu17-jdk
- - export JAVA_HOME=/usr/lib/jvm/zulu17
- - echo "USE mysql;\nALTER USER 'root'@'localhost' IDENTIFIED BY 'mysql';\n" | mysql -u root
- - mysql -u root -pmysql -e 'CREATE DATABASE IF NOT EXISTS `fineract_tenants`;'
- - mysql -u root -pmysql -e 'CREATE DATABASE IF NOT EXISTS `fineract_default`;'
-# Hardcoding the time zone is a temporary fix for https://issues.apache.org/jira/browse/FINERACT-723
- - export TZ=Asia/Kolkata
+ - sudo apt-get -yq install zulu11-jdk
+ - export JAVA_HOME=/usr/lib/jvm/zulu11
Review comment:
ah... didn't see that... that stuff is not necessary at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757837024
##########
File path: fineract-provider/build.gradle
##########
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
contents {
from bootJar
- from war
Review comment:
Ah, that... it should do something... good catch, I'll look at that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757838707
##########
File path: fineract-provider/build.gradle
##########
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
contents {
from bootJar
- from war
Review comment:
... actually it still does something (even creates the SHA512 file). The command is:
```
./gradlew -Pfineract.release clean build binaryDistTar
```
My plan was to replace that stitched together process with https://jreleaser.org/ ... less moving parts, proper Gradle plugin.
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java
##########
@@ -45,6 +48,12 @@
private static final String LOAN_PRODUCT_SHORT_NAME = "loanProductShortName";
private static final String SAVINGS_PRODUCT_SHORT_NAME = "savingsProductShortName";
private static final String SHARE_PRODUCT_SHORT_NAME = "sharesProductShortName";
+ private final ConfigurationReadPlatformService configurationReadPlatformService;
+
+ @Autowired
+ public AccountNumberGenerator(final ConfigurationReadPlatformService configurationReadPlatformService) {
+ this.configurationReadPlatformService = configurationReadPlatformService;
+ }
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-1003321397
@vidakovic I know you've been busy, but there's lots of great stuff here - hope you have some time to get these ready for merging! Perhaps it would be possible to break this to smaller incremental fixes - e.g. one PR for the Java 17 support, another one to move WAR to a separate module, another PR to fix the Docker parameters etc...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
ptuomola commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757840732
##########
File path: fineract-provider/build.gradle
##########
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
contents {
from bootJar
- from war
Review comment:
Ok great - let me try that command, I was assuming the build would automatically be taken care of as a dependency. Will update the README if it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-981351366
@ptuomola ... well... step by step sometimes doesn't work. Docker Compose on Github Actions is just not working, so I replaced the integration test setup as well (which was anyway my ultimate goal):
Locally it's already working like a charm. My stretch goal of running tests in parallel doesn't work just yet, but that wasn't there with Tomcat Cargo either, so no problem.
My changes are quite minimal (just added one test base class and one annotation per test class). This solution is using Testcontainers.
Let's see if Github Actions runs this now (it should; Testcontainers are also on GH and run their tests there).
So much easier now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-980826177
... not sure if my comment made it to GH... so here again:
We can do that (environment variables to configure basic auth vs. oauth)... could we just do this in another iteration/PR? Just to avoid piling up too many changes here. I'm working in parallel with @hiteshprajapati on a follow up PR that will take full advantage of your improvements (aka Java config). I promise that this will cover your request... the build time copy and paste of different application.properties files is anyway not a best practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic closed pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic closed pull request #1986:
URL: https://github.com/apache/fineract/pull/1986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-1030711171
This PR is obsolete and was split up in smaller chunks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757833811
##########
File path: fineract-provider/build.gradle
##########
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
contents {
from bootJar
- from war
Review comment:
You got me ;-) ... that one would need rework too if we want to maintain the WAR files. I have no sense how often the WAR files are still used. I'd argue that it's outdated and that those who want it could easily build from distribution sources. But that's just my 2 cents. If a wider audience still needs this then I'll figure something out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757835136
##########
File path: .travis.yml
##########
@@ -57,13 +48,8 @@ install:
- curl -O https://cdn.azul.com/zulu/bin/zulu-repo_1.0.0-3_all.deb
- sudo apt-get -yq install ./zulu-repo_1.0.0-3_all.deb
- sudo apt-get -q update
- - sudo apt-get -yq install zulu17-jdk
- - export JAVA_HOME=/usr/lib/jvm/zulu17
- - echo "USE mysql;\nALTER USER 'root'@'localhost' IDENTIFIED BY 'mysql';\n" | mysql -u root
- - mysql -u root -pmysql -e 'CREATE DATABASE IF NOT EXISTS `fineract_tenants`;'
- - mysql -u root -pmysql -e 'CREATE DATABASE IF NOT EXISTS `fineract_default`;'
-# Hardcoding the time zone is a temporary fix for https://issues.apache.org/jira/browse/FINERACT-723
- - export TZ=Asia/Kolkata
+ - sudo apt-get -yq install zulu11-jdk
+ - export JAVA_HOME=/usr/lib/jvm/zulu11
Review comment:
Fixed
##########
File path: fineract-provider/build.gradle
##########
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
- enabled = false
+jib {
+ from {
+ // image = 'azul/zulu-openjdk-alpine:17-jre' // once we get rid of OpenJPA we could reduce space significantly
+ image = 'azul/zulu-openjdk-alpine:17'
+ }
+
+ to {
+ image = 'fineract'
+ tags = [
+ "${releaseVersion}",
+ 'latest'
+ ]
+ }
+
+ container {
+ creationTime = 'USE_CURRENT_TIMESTAMP'
+ jvmFlags = [
+ '-Duser.home=/data',
+ '-Xmx1G',
+ '-Xms1G',
+ '-XshowSettings:vm',
+ '-XX:+UseContainerSupport',
+ '-XX:+UseStringDeduplication',
+ '-XX:MinRAMPercentage=25',
+ '-XX:MaxRAMPercentage=80'
+ ]
+ args = [
+ '-Dspring.profiles.active=basicauth',
+ '-Dfile.encoding=UTF-8',
+ '-Duser.timezone=UTC',
Review comment:
Alright... I'll set this in the Docker Compose file, no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
ptuomola commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757834318
##########
File path: fineract-provider/build.gradle
##########
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
- enabled = false
+jib {
+ from {
+ // image = 'azul/zulu-openjdk-alpine:17-jre' // once we get rid of OpenJPA we could reduce space significantly
+ image = 'azul/zulu-openjdk-alpine:17'
+ }
+
+ to {
+ image = 'fineract'
+ tags = [
+ "${releaseVersion}",
+ 'latest'
+ ]
+ }
+
+ container {
+ creationTime = 'USE_CURRENT_TIMESTAMP'
+ jvmFlags = [
+ '-Duser.home=/data',
+ '-Xmx1G',
+ '-Xms1G',
+ '-XshowSettings:vm',
+ '-XX:+UseContainerSupport',
+ '-XX:+UseStringDeduplication',
+ '-XX:MinRAMPercentage=25',
+ '-XX:MaxRAMPercentage=80'
+ ]
+ args = [
+ '-Dspring.profiles.active=basicauth',
+ '-Dfile.encoding=UTF-8',
+ '-Duser.timezone=UTC',
Review comment:
Yes - I didn't mean changing the default if it's possible for us to override it for the integration tests. Unfortunately I think there's around 20-30 tests that fail at different times of day (some before midnight, some after midnight etc) if the timezone is not set to Asia/Kalkuta
##########
File path: fineract-provider/build.gradle
##########
@@ -289,7 +307,6 @@ distributions {
distributionBaseName = "apache-fineract-binary"
contents {
from bootJar
- from war
Review comment:
Sorry - I didn't mean we should distribute the WAR file - I don't think that's necessary. But when I tried to use distTar I could not get it to do anything at all - not even build a tar file with the bootJar in it. Does it work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-1003410481
@ptuomola I'll take care of this today and tomorrow... will take advantage that other things are calming down... at least for a bit :-) ... will try to break it up into smaller pieces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-1026338441
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#discussion_r757836960
##########
File path: fineract-provider/build.gradle
##########
@@ -274,10 +252,50 @@ bootJar {
classifier = ''
}
-bootWar {
- enabled = false
+jib {
+ from {
+ // image = 'azul/zulu-openjdk-alpine:17-jre' // once we get rid of OpenJPA we could reduce space significantly
+ image = 'azul/zulu-openjdk-alpine:17'
+ }
+
+ to {
+ image = 'fineract'
+ tags = [
+ "${releaseVersion}",
+ 'latest'
+ ]
+ }
+
+ container {
+ creationTime = 'USE_CURRENT_TIMESTAMP'
+ jvmFlags = [
+ '-Duser.home=/data',
+ '-Xmx1G',
+ '-Xms1G',
+ '-XshowSettings:vm',
+ '-XX:+UseContainerSupport',
+ '-XX:+UseStringDeduplication',
+ '-XX:MinRAMPercentage=25',
+ '-XX:MaxRAMPercentage=80'
+ ]
+ args = [
+ '-Dspring.profiles.active=basicauth',
+ '-Dfile.encoding=UTF-8',
+ '-Duser.timezone=UTC',
Review comment:
Done. The complete entry point is now available in the Docker Compose file. Serves also as an example for other configuration (e. g. mem reservation etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1986: FINERACT-1446: Docker image build with Jib and JDK 17 fixes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1986:
URL: https://github.com/apache/fineract/pull/1986#issuecomment-1002820187
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org