[superset] branch master updated: fix: Regression on Data and Alerts & Reports Headers (#19850)

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 7645eac31f fix: Regression on Data and Alerts & Reports Headers (#19850)
7645eac31f is described below

commit 7645eac31f2cc583906f504e8896e4a119eee751
Author: Diego Medina <di...@gmail.com>
AuthorDate: Tue Apr 26 16:08:07 2022 -0400

    fix: Regression on Data and Alerts & Reports Headers (#19850)
---
 superset-frontend/src/views/components/SubMenu.tsx | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/views/components/SubMenu.tsx b/superset-frontend/src/views/components/SubMenu.tsx
index 2ae897196b..3ac1253709 100644
--- a/superset-frontend/src/views/components/SubMenu.tsx
+++ b/superset-frontend/src/views/components/SubMenu.tsx
@@ -67,7 +67,7 @@ const StyledHeader = styled.div`
     padding-left: 10px;
   }
   .menu {
-    background-color: white;
+    background-color: ${({ theme }) => theme.colors.grayscale.light5};
     .ant-menu-horizontal {
       line-height: inherit;
       .ant-menu-item {
@@ -88,7 +88,8 @@ const StyledHeader = styled.div`
   }
 
   .menu .ant-menu-item {
-    li {
+    li,
+    div {
       a,
       div {
         font-size: ${({ theme }) => theme.typography.sizes.s}px;
@@ -98,6 +99,10 @@ const StyledHeader = styled.div`
           margin: 0;
           padding: ${({ theme }) => theme.gridUnit * 4}px;
           line-height: ${({ theme }) => theme.gridUnit * 5}px;
+
+          &:hover {
+            text-decoration: none;
+          }
         }
       }
 
@@ -106,11 +111,14 @@ const StyledHeader = styled.div`
           ${({ theme }) => theme.gridUnit * 4}px;
       }
     }
+
     li.active > a,
     li.active > div,
+    div.active > div,
     li > a:hover,
     li > a:focus,
-    li > div:hover {
+    li > div:hover,
+    div > div:hover {
       background: ${({ theme }) => theme.colors.secondary.light4};
       border-bottom: none;
       border-radius: ${({ theme }) => theme.borderRadius}px;
@@ -148,6 +156,7 @@ const StyledHeader = styled.div`
 const styledDisabled = (theme: SupersetTheme) => css`
   color: ${theme.colors.grayscale.base};
   backgroundColor: ${theme.colors.grayscale.light2}};
+
   .ant-menu-item:hover {
     color: ${theme.colors.grayscale.base};
     cursor: default;