You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tharindu Mathew (JIRA)" <ji...@apache.org> on 2008/07/12 09:40:31 UTC
[jira] Created: (HARMONY-5909) Incorrect values with Asia/Colombo
Time Zone
Incorrect values with Asia/Colombo Time Zone
--------------------------------------------
Key: HARMONY-5909
URL: https://issues.apache.org/jira/browse/HARMONY-5909
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Tharindu Mathew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5909) Incorrect values with Asia/Colombo
Time Zone
Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613062#action_12613062 ]
Senaka Fernando commented on HARMONY-5909:
------------------------------------------
Tharindu,
Indeed, Colombo is not the only city that would have these issues... Also, according to SimpleTimeZone.java, I see no issue in doing this.
/**
* Constructs a new SimpleTimeZone using the specified offset for standard
* time from GMT and the specified time zone ID.
*
* @param offset
* the offset from GMT of standard time in milliseconds
* @param name
* the time zone ID
*/
public SimpleTimeZone(int offset, String name) { }
As you see ONE_HOUR = 1000*60*60 = 3600000
And, ONE_HOUR * 5.5 = 19800000, which is not a float value. :)...
Regards,
Senaka
> Incorrect values with Asia/Colombo Time Zone
> --------------------------------------------
>
> Key: HARMONY-5909
> URL: https://issues.apache.org/jira/browse/HARMONY-5909
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tharindu Mathew
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5909) Incorrect values with Asia/Colombo
Time Zone
Posted by "Tharindu Mathew (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613057#action_12613057 ]
Tharindu Mathew commented on HARMONY-5909:
------------------------------------------
The TimeZones getTimeZone() method has incorrect values entered for "Asia/Colombo":
new SimpleTimeZone(6 * ONE_HOUR, "Asia/Colombo")
which should be.
new SimpleTimeZone(5.5 * ONE_HOUR, "Asia/Colombo")
but this cannot be fixed because it does not allow float as arguments, and the constructor uses com.ibm.icu.util Classes which cannot be modified:
public SimpleTimeZone(int offset, String name) {
setID(name);
rawOffset = offset;
icuTZ = com.ibm.icu.util.TimeZone.getTimeZone(name);
if (icuTZ instanceof com.ibm.icu.util.SimpleTimeZone) {
isSimple = true;
icuTZ.setRawOffset(offset);
}
useDaylight = icuTZ.useDaylightTime();
}
> Incorrect values with Asia/Colombo Time Zone
> --------------------------------------------
>
> Key: HARMONY-5909
> URL: https://issues.apache.org/jira/browse/HARMONY-5909
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tharindu Mathew
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5909) [classlib][luni] Incorrect values
with Asia/Colombo Time Zone
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov resolved HARMONY-5909.
--------------------------------------
Resolution: Fixed
I've just committed (at r678143) the fix that replaces
new SimpleTimeZone(6 * ONE_HOUR, "Asia/Colombo")
with
new SimpleTimeZone(5 * ONE_HOUR + HALF_HOUR, "Asia/Colombo")
Please let me know it something else needs fixing.
> [classlib][luni] Incorrect values with Asia/Colombo Time Zone
> -------------------------------------------------------------
>
> Key: HARMONY-5909
> URL: https://issues.apache.org/jira/browse/HARMONY-5909
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tharindu Mathew
> Assignee: Alexei Zakharov
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5909) Incorrect values with Asia/Colombo
Time Zone
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov reassigned HARMONY-5909:
----------------------------------------
Assignee: Alexei Zakharov
> Incorrect values with Asia/Colombo Time Zone
> --------------------------------------------
>
> Key: HARMONY-5909
> URL: https://issues.apache.org/jira/browse/HARMONY-5909
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tharindu Mathew
> Assignee: Alexei Zakharov
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5909) [classlib][luni] Incorrect values
with Asia/Colombo Time Zone
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess closed HARMONY-5909.
---------------------------------
Works for me. Closing.
> [classlib][luni] Incorrect values with Asia/Colombo Time Zone
> -------------------------------------------------------------
>
> Key: HARMONY-5909
> URL: https://issues.apache.org/jira/browse/HARMONY-5909
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tharindu Mathew
> Assignee: Alexei Zakharov
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5909) [classlib][luni] Incorrect values
with Asia/Colombo Time Zone
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov updated HARMONY-5909:
-------------------------------------
Summary: [classlib][luni] Incorrect values with Asia/Colombo Time Zone (was: Incorrect values with Asia/Colombo Time Zone)
> [classlib][luni] Incorrect values with Asia/Colombo Time Zone
> -------------------------------------------------------------
>
> Key: HARMONY-5909
> URL: https://issues.apache.org/jira/browse/HARMONY-5909
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Tharindu Mathew
> Assignee: Alexei Zakharov
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.