You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/06/30 15:04:28 UTC

[jira] [Created] (WICKET-3851) Remove usage of System.gc() in Wicket code

Remove usage of System.gc() in Wicket code
------------------------------------------

                 Key: WICKET-3851
                 URL: https://issues.apache.org/jira/browse/WICKET-3851
             Project: Wicket
          Issue Type: Bug
          Components: wicket-core
    Affects Versions: 1.5-RC5.1
            Reporter: Martin Grigorov
            Assignee: Martin Grigorov


org.apache.wicket.util.file.Files.remove(File) calls System.gc() when a file cannot be removed for any reason.
This call popped up in our performance tests.

I suggest to try to delete the file at most N times and if it still not deleted then log a warning and schedule it for deletion when the JVM exists (java.io.File.deleteOnExit())

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-3851) Remove usage of System.gc() in Wicket code

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3851.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC6

Files.remove() was the only place where System.gc() has been used.

> Remove usage of System.gc() in Wicket code
> ------------------------------------------
>
>                 Key: WICKET-3851
>                 URL: https://issues.apache.org/jira/browse/WICKET-3851
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC5.1
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>             Fix For: 1.5-RC6
>
>
> org.apache.wicket.util.file.Files.remove(File) calls System.gc() when a file cannot be removed for any reason.
> This call popped up in our performance tests.
> I suggest to try to delete the file at most N times and if it still not deleted then log a warning and schedule it for deletion when the JVM exists (java.io.File.deleteOnExit())

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira