[GitHub] [pinot] walterddr commented on a diff in pull request #9496: add tests for LIMIT/OFFSET in QueryRunnerTest [MINOR]

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9496:
URL: https://github.com/apache/pinot/pull/9496#discussion_r984723619


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java:
##########
@@ -151,6 +151,8 @@ private Object[][] provideTestSql() {
         new Object[]{"SELECT * FROM b ORDER BY col1, col2 DESC LIMIT 3"},
         new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 10"},
         new Object[]{"SELECT * FROM a ORDER BY col1 LIMIT 20"},
+        new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 1, 2"},
+        new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 2 OFFSET 1"},

Review Comment:
   Test should be added IMO if we support the feature in SQL syntax.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org