You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by tluce <gi...@git.apache.org> on 2017/11/30 22:13:15 UTC
[GitHub] tomcat pull request #95: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
GitHub user tluce opened a pull request:
https://github.com/apache/tomcat/pull/95
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223
Added the description of each mbean attribute to the documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tluce/tomcat trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit a9dcbccb9f3e3715017cf3af9e3705fab689cc60
Author: Tayo Dagunro <tl...@gmail.com>
Date: 2017-11-30T22:08:40Z
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223
Added the description of each mbean attribute to the documentation.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #95: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/95
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #95: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/95
Thanks for the patch. There wasn't anything wrong with it but the more I thought about it, the more I thought that referencing the DTD directly was a better solution.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #95: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61223
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/95
This is a partial fix. It only addresses the attributes of the mbean element.
I'm wondering if, rather than duplicate the comments in the DTD file, if it would be simpler to copy the DTD to the docs and link to the DTD.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org