You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/09/10 16:11:08 UTC

[jira] [Created] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Robert Muir created LUCENE-4371:
-----------------------------------

             Summary: consider refactoring slicer to indexinput.slice
                 Key: LUCENE-4371
                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
             Project: Lucene - Core
          Issue Type: Task
            Reporter: Robert Muir


>From LUCENE-4364:

{quote}
In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
{quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453320#comment-13453320 ] 

Michael McCandless commented on LUCENE-4371:
--------------------------------------------

I don't think the default impl (SlicedIndexInput) should overrided BII's copyBytes?  Seems ... spooky.
                
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452245#comment-13452245 ] 

Robert Muir commented on LUCENE-4371:
-------------------------------------

Well realistically I'm not sure we have to fix this for 4.0? We could do this one later in a fairly backwards compatible/compatiblish way:

E.g. a good approach might be to make Directory.createSlicer just call clone/slice.

Another safer alternative might introduce a minor break: by making that deprecation final and having CFS code just use slice() directly,
listing it in the backwards break section. this would just be a minor break in expert usage.
                
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453310#comment-13453310 ] 

Michael McCandless commented on LUCENE-4371:
--------------------------------------------

+1

I think having II implement slice is much cleaner than Directory having to implement createSlicer returning an IndexInputSlicer with only one method.
                
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452166#comment-13452166 ] 

Uwe Schindler commented on LUCENE-4371:
---------------------------------------

+1 to rermove the slicer! I was thinking about that the whole time and it really makes it easier.

In general for 4.0, we should make the slice method abstract and *not* provide a default implementation. In most cases its as easy to implement like clone().
                
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-4371:
--------------------------------

    Attachment: LUCENE-4371.patch
    
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-4371:
--------------------------------

    Attachment: LUCENE-4371.patch

just syncing the patch up to trunk.

part of the funkiness i dont like is e.g. NIOFSIndexInput extends SimpleIndexInput. This is not good. I will see if i can clear that up in a separate issue.
                
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch, LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452001#comment-13452001 ] 

Robert Muir commented on LUCENE-4371:
-------------------------------------

fyi there are some things i dont like about it, and i didnt look at the directories in misc/.

but its worth thinking about i guess.
                
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453322#comment-13453322 ] 

Robert Muir commented on LUCENE-4371:
-------------------------------------

I agree Mike, i wanted to remove it... but I'm afraid!

I also dont understand why we have DataOutput.copyBytes(DataInput), and also IndexInput.copyBytes(IndexOutput).
Is this all really necessary?
                
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4371) consider refactoring slicer to indexinput.slice

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-4371:
--------------------------------

    Attachment: LUCENE-4371.patch

just an updated patch after LUCENE-4380. still work to be done.
                
> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch, LUCENE-4371.patch, LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs? Just make the slice(...) method return the current BufferedIndexInput-based one. This could be another issue, once this is in.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org