You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/01 18:08:43 UTC

[GitHub] [arrow] thisisnic commented on a change in pull request #11971: ARROW-15040: [R] Enable write_csv_arrow to take a RecordBatchReader as input

thisisnic commented on a change in pull request #11971:
URL: https://github.com/apache/arrow/pull/11971#discussion_r796866449



##########
File path: r/R/csv.R
##########
@@ -692,7 +692,7 @@ write_csv_arrow <- function(x,
     x <- Table$create(x)
   }
 
-  assert_that(is_writable_table(x))
+  assert_that(is_writable_table(x) | inherits(x, "FileSystemDataset"))

Review comment:
       They can't yet; there are some open tickets about this:
   
   * [ARROW-14742: [C++] Allow ParquetWriter to take a RecordBatchReader as input](https://issues.apache.org/jira/browse/ARROW-14742)
   * [ARROW-15405: [R] Allow all file writers to write from a RecordBatchReader](https://issues.apache.org/jira/browse/ARROW-15405)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org