You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/13 03:31:16 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37487: [SPARK-40053][CORE][SQL][TESTS] Ignore test of Spark 2.x and restrict test Python version for `HiveExternalCatalogVersionsSuite`

HyukjinKwon commented on code in PR #37487:
URL: https://github.com/apache/spark/pull/37487#discussion_r945048394


##########
core/src/main/scala/org/apache/spark/TestUtils.scala:
##########
@@ -281,9 +281,13 @@ private[spark] object TestUtils {
     attempt.isSuccess && attempt.get == 0
   }
 
-  def isPythonVersionAtLeast38(): Boolean = {
+  def isPythonVersionAtLeast37(): Boolean = isPythonVersionAtLeast(3, 7, 0)
+
+  def isPythonVersionAtLeast38(): Boolean = isPythonVersionAtLeast(3, 8, 0)

Review Comment:
   Let's remove if this isn't used now in the codebase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org