You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Вадим Опольский <va...@gmail.com> on 2017/05/10 14:03:26 UTC

Re: IGNITE-1084 is ready for review

Hello guys!

Semen, Sergey is issue
https://issues.apache.org/jira/browse/IGNITE-1084 resolved
?

Vadim Opolski

2017-04-19 14:06 GMT+03:00 Semyon Boikov <sb...@gridgain.com>:

> Vadim,
>
> I found that real cause of IGNITE-1084 is IGNITE-4760, so suggested test
> fix in pull/1828 is not correct. I added new comments in IGNITE-4760,
> please take a look.
>
> Thanks,
> Semyon
>
> On Wed, Apr 19, 2017 at 12:17 PM, Вадим Опольский <va...@gmail.com>
> wrote:
>
>> Hello guys!
>>
>> The issue IGNITE-1084 https://issues.apache.org/jira/browse/IGNITE-1794 fixed
>> originally by Milap Wadhwa.
>>
>> I reassigned it on myself because she didn't make improvements from Anton
>> Vinogradov's comments. Also I just finished another issue with hibernate's
>> test.
>>
>> Review it please - https://github.com/apache/ignite/pull/1828
>>
>> Vadim Opolski
>>
>
>

Re: IGNITE-1084 is ready for review

Posted by Semyon Boikov <sb...@gridgain.com>.
Hi Vadim,

I see that testNaturalIdCache still fails for
HibernateL2CacheTransactionalSelfTest, need investigate and find root cause
of failure.

Thanks

On Wed, May 10, 2017 at 5:03 PM, Вадим Опольский <va...@gmail.com>
wrote:

> Hello guys!
>
> Semen, Sergey is issue https://issues.apache.org/jira/browse/IGNITE-1084 resolved
> ?
>
> Vadim Opolski
>
> 2017-04-19 14:06 GMT+03:00 Semyon Boikov <sb...@gridgain.com>:
>
>> Vadim,
>>
>> I found that real cause of IGNITE-1084 is IGNITE-4760, so suggested test
>> fix in pull/1828 is not correct. I added new comments in IGNITE-4760,
>> please take a look.
>>
>> Thanks,
>> Semyon
>>
>> On Wed, Apr 19, 2017 at 12:17 PM, Вадим Опольский <va...@gmail.com>
>> wrote:
>>
>>> Hello guys!
>>>
>>> The issue IGNITE-1084 https://issues.apache.org/jira/browse/IGNITE-1794 fixed
>>> originally by Milap Wadhwa.
>>>
>>> I reassigned it on myself because she didn't make improvements from
>>> Anton Vinogradov's comments. Also I just finished another issue with
>>> hibernate's test.
>>>
>>> Review it please - https://github.com/apache/ignite/pull/1828
>>>
>>> Vadim Opolski
>>>
>>
>>
>