You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/12/17 22:39:59 UTC

[GitHub] [mynewt-core] ncasaril commented on pull request #2441: hw/mcu/nordic/nrf52xxx: Using hfxo_request and release. Addresses #2393.

ncasaril commented on pull request #2441:
URL: https://github.com/apache/mynewt-core/pull/2441#issuecomment-747744572


   @wes3 and @kasjer Thanks for your input. 
   I've tried to accomodate your suggestions with moving the wait code into hfxo_request. 
   It feels like a good solution and that's now the only place that I can find that enables the HFCLK. 
   
   That said, I think the NRF_CLOCK->HFCLKSTAT isn't used correctly to detect if the HFXO is used. It only checks if the task has been started, not if we're actually running off the HFXO. 
   
   Leave me with it for a bit and I'll see if I can get clarity into how it's meant to work. 
   
   So, not ready for merge just yet.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org