[jira] [Resolved] (FREEMARKER-15) Unextract jar-s inside src/test, generate them instead

["Daniel Dekany (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FREEMARKER-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dekany resolved FREEMARKER-15.
-------------------------------------
    Resolution: Fixed
      Assignee: Daniel Dekany

Fixed in 2.3.24-gae-stabilization (for now), with message:
Got rid of jar-s (and class binaries inside) in the test source code. I haven't implemented this as part of the build script, to help migrating to other build tools later. Instead, the JUnit test itself builds the required jar-s on the fly.

> Unextract jar-s inside src/test, generate them instead
> ------------------------------------------------------
>
>                 Key: FREEMARKER-15
>                 URL: https://issues.apache.org/jira/browse/FREEMARKER-15
>             Project: Apache Freemarker
>          Issue Type: Task
>          Components: engine
>            Reporter: Daniel Dekany
>            Assignee: Daniel Dekany
>
> It seems it's a legal/policy problem that we have those binaries in the source release, despite they were created as part of the project, and are referred to in the NOTICE file. So we must generate them on-the-fly from an extracted from. Also then WebappLocalFreemarkerServlet.class need to be compiled from its source form.
> ./src/test/resources/freemarker/ext/jsp/webapps/config/WEB-INF/lib/templates.jar
> ./src/test/resources/freemarker/ext/jsp/webapps/config/WEB-INF/lib/WebappLocalFreemarkerServlet.jar
> ./src/test/resources/freemarker/ext/jsp/webapps/tldDiscovery/WEB-INF/lib/taglib-foo.jar
> ./src/test/resources/freemarker/ext/jsp/webapps/tldDiscovery/WEB-INF/taglib 2.jar



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)