You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "ijokarumawak@gmail.com Koji" <ij...@gmail.com> on 2018/08/07 06:45:52 UTC
Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-2157
https://issues.apache.org/jira/browse/RANGER-2157
Repository: ranger
Description
-------
Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
plugin-nifi-registry/.gitignore PRE-CREATION
plugin-nifi-registry/pom.xml PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
pom.xml 19a5e71b4
src/main/assembly/admin-web.xml d0f354520
Diff: https://reviews.apache.org/r/68211/diff/1/
Testing
-------
Tested on local machine.
In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
Thanks,
ijokarumawak@gmail.com Koji
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/#review208143
-----------------------------------------------------------
Ship it!
Fix it and ship it
- Ramesh Mani
On Aug. 17, 2018, 10:55 a.m., ijokarumawak@gmail.com Koji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68211/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 10:55 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2157
> https://issues.apache.org/jira/browse/RANGER-2157
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
> plugin-nifi-registry/.gitignore PRE-CREATION
> plugin-nifi-registry/pom.xml PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
> pom.xml 472199d5d
> src/main/assembly/admin-web.xml d0f354520
>
>
> Diff: https://reviews.apache.org/r/68211/diff/3/
>
>
> Testing
> -------
>
> Tested on local machine.
>
> In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
>
>
> Thanks,
>
> ijokarumawak@gmail.com Koji
>
>
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/#review208139
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On Aug. 17, 2018, 10:55 a.m., ijokarumawak@gmail.com Koji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68211/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 10:55 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2157
> https://issues.apache.org/jira/browse/RANGER-2157
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
> plugin-nifi-registry/.gitignore PRE-CREATION
> plugin-nifi-registry/pom.xml PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
> pom.xml 472199d5d
> src/main/assembly/admin-web.xml d0f354520
>
>
> Diff: https://reviews.apache.org/r/68211/diff/3/
>
>
> Testing
> -------
>
> Tested on local machine.
>
> In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
>
>
> Thanks,
>
> ijokarumawak@gmail.com Koji
>
>
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/#review208142
-----------------------------------------------------------
plugin-nifi-registry/pom.xml
Lines 32 (patched)
<https://reviews.apache.org/r/68211/#comment291926>
version has to be 2.0.0-SNAPSHOT, otherwise build fails with PMD error.
- Ramesh Mani
On Aug. 17, 2018, 10:55 a.m., ijokarumawak@gmail.com Koji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68211/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 10:55 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2157
> https://issues.apache.org/jira/browse/RANGER-2157
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
> plugin-nifi-registry/.gitignore PRE-CREATION
> plugin-nifi-registry/pom.xml PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
> pom.xml 472199d5d
> src/main/assembly/admin-web.xml d0f354520
>
>
> Diff: https://reviews.apache.org/r/68211/diff/3/
>
>
> Testing
> -------
>
> Tested on local machine.
>
> In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
>
>
> Thanks,
>
> ijokarumawak@gmail.com Koji
>
>
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by "ijokarumawak@gmail.com Koji" <ij...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/#review208477
-----------------------------------------------------------
Ship it!
Ship It!
- ijokarumawak@gmail.com Koji
On Sept. 3, 2018, 12:09 a.m., ijokarumawak@gmail.com Koji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68211/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2018, 12:09 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2157
> https://issues.apache.org/jira/browse/RANGER-2157
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
> plugin-nifi-registry/.gitignore PRE-CREATION
> plugin-nifi-registry/pom.xml PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
> pom.xml 472199d5d
> src/main/assembly/admin-web.xml d0f354520
>
>
> Diff: https://reviews.apache.org/r/68211/diff/4/
>
>
> Testing
> -------
>
> Tested on local machine.
>
> In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
>
>
> Thanks,
>
> ijokarumawak@gmail.com Koji
>
>
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/#review208629
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Sept. 13, 2018, 12:25 p.m., ijokarumawak@gmail.com Koji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68211/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2018, 12:25 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2157
> https://issues.apache.org/jira/browse/RANGER-2157
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
> plugin-nifi-registry/.gitignore PRE-CREATION
> plugin-nifi-registry/pom.xml PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
> pom.xml 472199d5d
> src/main/assembly/admin-web.xml d0f354520
>
>
> Diff: https://reviews.apache.org/r/68211/diff/5/
>
>
> Testing
> -------
>
> Tested on local machine.
>
> In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
>
>
> Thanks,
>
> ijokarumawak@gmail.com Koji
>
>
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by "ijokarumawak@gmail.com Koji" <ij...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/
-----------------------------------------------------------
(Updated Sept. 13, 2018, 12:25 p.m.)
Review request for ranger.
Changes
-------
Removed unnecessary imports.
Bugs: RANGER-2157
https://issues.apache.org/jira/browse/RANGER-2157
Repository: ranger
Description
-------
Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
plugin-nifi-registry/.gitignore PRE-CREATION
plugin-nifi-registry/pom.xml PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
pom.xml 472199d5d
src/main/assembly/admin-web.xml d0f354520
Diff: https://reviews.apache.org/r/68211/diff/5/
Changes: https://reviews.apache.org/r/68211/diff/4-5/
Testing
-------
Tested on local machine.
In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
Thanks,
ijokarumawak@gmail.com Koji
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/#review208484
-----------------------------------------------------------
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java
Lines 21 (patched)
<https://reviews.apache.org/r/68211/#comment292427>
I am getting below PMD violations. Could you please take a look?
```
[INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-nifi-registry-plugin ---
[INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:21 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package.
[INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:22 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package.
[INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:23 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package.
[INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:24 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package.
```
- Velmurugan Periasamy
On Sept. 3, 2018, 12:09 a.m., ijokarumawak@gmail.com Koji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68211/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2018, 12:09 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2157
> https://issues.apache.org/jira/browse/RANGER-2157
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
> plugin-nifi-registry/.gitignore PRE-CREATION
> plugin-nifi-registry/pom.xml PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
> pom.xml 472199d5d
> src/main/assembly/admin-web.xml d0f354520
>
>
> Diff: https://reviews.apache.org/r/68211/diff/4/
>
>
> Testing
> -------
>
> Tested on local machine.
>
> In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
>
>
> Thanks,
>
> ijokarumawak@gmail.com Koji
>
>
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by "ijokarumawak@gmail.com Koji" <ij...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/
-----------------------------------------------------------
(Updated Sept. 3, 2018, 12:09 a.m.)
Review request for ranger.
Changes
-------
Updated version inside the plugin pom.xml to 2.0.0-SNAPSHOT.
Bugs: RANGER-2157
https://issues.apache.org/jira/browse/RANGER-2157
Repository: ranger
Description
-------
Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
plugin-nifi-registry/.gitignore PRE-CREATION
plugin-nifi-registry/pom.xml PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
pom.xml 472199d5d
src/main/assembly/admin-web.xml d0f354520
Diff: https://reviews.apache.org/r/68211/diff/4/
Changes: https://reviews.apache.org/r/68211/diff/3-4/
Testing
-------
Tested on local machine.
In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
Thanks,
ijokarumawak@gmail.com Koji
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by "ijokarumawak@gmail.com Koji" <ij...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 10:55 a.m.)
Review request for ranger.
Changes
-------
Changed service id from 12 to 13 since 12 has been already taken by Kylin.
Bugs: RANGER-2157
https://issues.apache.org/jira/browse/RANGER-2157
Repository: ranger
Description
-------
Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
plugin-nifi-registry/.gitignore PRE-CREATION
plugin-nifi-registry/pom.xml PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
pom.xml 472199d5d
src/main/assembly/admin-web.xml d0f354520
Diff: https://reviews.apache.org/r/68211/diff/3/
Changes: https://reviews.apache.org/r/68211/diff/2-3/
Testing
-------
Tested on local machine.
In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
Thanks,
ijokarumawak@gmail.com Koji
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by "ijokarumawak@gmail.com Koji" <ij...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/
-----------------------------------------------------------
(Updated Aug. 9, 2018, 2:27 a.m.)
Review request for ranger.
Changes
-------
Incorporated review comments.
Bugs: RANGER-2157
https://issues.apache.org/jira/browse/RANGER-2157
Repository: ranger
Description
-------
Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
plugin-nifi-registry/.gitignore PRE-CREATION
plugin-nifi-registry/pom.xml PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
pom.xml 472199d5d
src/main/assembly/admin-web.xml d0f354520
Diff: https://reviews.apache.org/r/68211/diff/2/
Changes: https://reviews.apache.org/r/68211/diff/1-2/
Testing
-------
Tested on local machine.
In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
Thanks,
ijokarumawak@gmail.com Koji
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by "ijokarumawak@gmail.com Koji" <ij...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/
-----------------------------------------------------------
(Updated Aug. 9, 2018, 2 a.m.)
Review request for ranger.
Bugs: RANGER-2157
https://issues.apache.org/jira/browse/RANGER-2157
Repository: ranger
Description
-------
Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
plugin-nifi-registry/.gitignore PRE-CREATION
plugin-nifi-registry/pom.xml PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
pom.xml 19a5e71b4
src/main/assembly/admin-web.xml d0f354520
Diff: https://reviews.apache.org/r/68211/diff/1/
Testing
-------
Tested on local machine.
In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
File Attachments (updated)
----------------
Fixed review comments
https://reviews.apache.org/media/uploaded/files/2018/08/09/d77d98e8-e54b-452e-851d-4c88a11f4cad__0002-RANGER-2157-Incorporated-review-comments.patch
Thanks,
ijokarumawak@gmail.com Koji
Re: Review Request 68211: RANGER-2157 Add NiFi Registry service
definition and NiFiRegistryClient
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68211/#review206932
-----------------------------------------------------------
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
Lines 72 (patched)
<https://reviews.apache.org/r/68211/#comment290099>
Intialize this connectivityStatus=true and make it false with error message where ever condition permits
you can do something like
if (Response.Status.OK.getStatusCode() != response.getStatus()) {
connectivityStatus = false;
errMsg = "Status Code = " + response.getStatus();
}
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
Lines 125 (patched)
<https://reviews.apache.org/r/68211/#comment290100>
Can this context be null, please do the null check if so.
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
Lines 180 (patched)
<https://reviews.apache.org/r/68211/#comment290102>
Can this hostname be null?
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java
Lines 198 (patched)
<https://reviews.apache.org/r/68211/#comment290103>
Move this as first statement in the method and return result instead of return new ArrayList<>();
plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java
Lines 64 (patched)
<https://reviews.apache.org/r/68211/#comment290104>
if (LOG.isDebugEnabled()) {
- Ramesh Mani
On Aug. 7, 2018, 6:45 a.m., ijokarumawak@gmail.com Koji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68211/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 6:45 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2157
> https://issues.apache.org/jira/browse/RANGER-2157
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 5e74da85a
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json PRE-CREATION
> plugin-nifi-registry/.gitignore PRE-CREATION
> plugin-nifi-registry/pom.xml PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java PRE-CREATION
> plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java PRE-CREATION
> plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java PRE-CREATION
> plugin-nifi-registry/src/test/resources/resources-response.json PRE-CREATION
> pom.xml 19a5e71b4
> src/main/assembly/admin-web.xml d0f354520
>
>
> Diff: https://reviews.apache.org/r/68211/diff/1/
>
>
> Testing
> -------
>
> Tested on local machine.
>
> In order to get NiFi Registry for integration tests, NiFi Registry needs to be built manually as the change is not released at NiFi Registry project yet. Please check [NiFi Registry Pull Request 131 for NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, especially this [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) file should be a starting point.
>
>
> Thanks,
>
> ijokarumawak@gmail.com Koji
>
>