You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/18 06:13:28 UTC
[GitHub] [arrow] emkornfield opened a new pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano Interval…
emkornfield opened a new pull request #12461:
URL: https://github.com/apache/arrow/pull/12461
…s to Python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano intervals to Pandas
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #12461:
URL: https://github.com/apache/arrow/pull/12461#discussion_r811990135
##########
File path: python/pyarrow/tests/test_array.py
##########
@@ -2329,6 +2329,11 @@ def test_interval_array_from_dateoffset():
nanoseconds=1),
DateOffset(months=0, days=0, microseconds=0, nanoseconds=0)]
+ assert arr.to_pandas().tolist() == expected_from_pandas
+ actual_list = pa.array([data]).to_pandas().tolist()
Review comment:
```suggestion
# nested list<interval> array conversion
actual_list = pa.array([data]).to_pandas().tolist()
```
(on first read it was not super obvious to me that `pa.array([data])` was creating a nested list array)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano intervals to Pandas
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12461:
URL: https://github.com/apache/arrow/pull/12461#issuecomment-1047905997
Benchmark runs are scheduled for baseline = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 and contender = 5680d209fd870f99134e2d7299b47acd90fabb8e. 5680d209fd870f99134e2d7299b47acd90fabb8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47a9f3ddb2e547e181e0f5c92572f935...99142f29b01b47bc963c702b87da051a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c6597e5a8b8f4ed392a27c60ab36b8a3...241f27fc813d4ecb96c234fd1bd99adc/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9ca02c7c57f74129adcea8004eaf9e9b...6972f96314454d3f87792b1d654b082f/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a891d30f4cfc48ba830fe794b2e14da6...6624357494094dda81f375a5a493c3d2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano intervals to Pandas
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12461:
URL: https://github.com/apache/arrow/pull/12461#issuecomment-1047905997
Benchmark runs are scheduled for baseline = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 and contender = 5680d209fd870f99134e2d7299b47acd90fabb8e. 5680d209fd870f99134e2d7299b47acd90fabb8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47a9f3ddb2e547e181e0f5c92572f935...99142f29b01b47bc963c702b87da051a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c6597e5a8b8f4ed392a27c60ab36b8a3...241f27fc813d4ecb96c234fd1bd99adc/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9ca02c7c57f74129adcea8004eaf9e9b...6972f96314454d3f87792b1d654b082f/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a891d30f4cfc48ba830fe794b2e14da6...6624357494094dda81f375a5a493c3d2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano intervals to Pandas
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #12461:
URL: https://github.com/apache/arrow/pull/12461#discussion_r811990135
##########
File path: python/pyarrow/tests/test_array.py
##########
@@ -2329,6 +2329,11 @@ def test_interval_array_from_dateoffset():
nanoseconds=1),
DateOffset(months=0, days=0, microseconds=0, nanoseconds=0)]
+ assert arr.to_pandas().tolist() == expected_from_pandas
+ actual_list = pa.array([data]).to_pandas().tolist()
Review comment:
```suggestion
# nested list<interval> array conversion
actual_list = pa.array([data]).to_pandas().tolist()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano intervals to Pandas
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12461:
URL: https://github.com/apache/arrow/pull/12461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano Interval…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12461:
URL: https://github.com/apache/arrow/pull/12461#issuecomment-1043974844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano intervals to Pandas
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12461:
URL: https://github.com/apache/arrow/pull/12461#issuecomment-1047905997
Benchmark runs are scheduled for baseline = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 and contender = 5680d209fd870f99134e2d7299b47acd90fabb8e. 5680d209fd870f99134e2d7299b47acd90fabb8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47a9f3ddb2e547e181e0f5c92572f935...99142f29b01b47bc963c702b87da051a/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c6597e5a8b8f4ed392a27c60ab36b8a3...241f27fc813d4ecb96c234fd1bd99adc/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9ca02c7c57f74129adcea8004eaf9e9b...6972f96314454d3f87792b1d654b082f/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a891d30f4cfc48ba830fe794b2e14da6...6624357494094dda81f375a5a493c3d2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano intervals to Pandas
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12461:
URL: https://github.com/apache/arrow/pull/12461#issuecomment-1047905997
Benchmark runs are scheduled for baseline = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 and contender = 5680d209fd870f99134e2d7299b47acd90fabb8e. 5680d209fd870f99134e2d7299b47acd90fabb8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47a9f3ddb2e547e181e0f5c92572f935...99142f29b01b47bc963c702b87da051a/)
[Finished :arrow_down:0.13% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c6597e5a8b8f4ed392a27c60ab36b8a3...241f27fc813d4ecb96c234fd1bd99adc/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9ca02c7c57f74129adcea8004eaf9e9b...6972f96314454d3f87792b1d654b082f/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a891d30f4cfc48ba830fe794b2e14da6...6624357494094dda81f375a5a493c3d2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12461: ARROW-15727: [Python] Allow converting lists of MonthDayNano intervals to Pandas
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12461:
URL: https://github.com/apache/arrow/pull/12461#issuecomment-1047905997
Benchmark runs are scheduled for baseline = 961ac3f01298ce90a3eeddfcb5a420c7d9894bf1 and contender = 5680d209fd870f99134e2d7299b47acd90fabb8e. 5680d209fd870f99134e2d7299b47acd90fabb8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47a9f3ddb2e547e181e0f5c92572f935...99142f29b01b47bc963c702b87da051a/)
[Finished :arrow_down:0.13% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c6597e5a8b8f4ed392a27c60ab36b8a3...241f27fc813d4ecb96c234fd1bd99adc/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9ca02c7c57f74129adcea8004eaf9e9b...6972f96314454d3f87792b1d654b082f/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a891d30f4cfc48ba830fe794b2e14da6...6624357494094dda81f375a5a493c3d2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org