You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/02/10 03:04:00 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #39961: [SPARK-42391][CORE][TESTS] Close live `AppStore` in the finally block for test cases
LuciferYang opened a new pull request, #39961:
URL: https://github.com/apache/spark/pull/39961
### What changes were proposed in this pull request?
`AppStatusStore.createLiveStore` will return `RocksDB` backend `AppStatusStore` when `LIVE_UI_LOCAL_STORE_DIR` or `LIVE_UI_LOCAL_STORE_DIR` is configured, it should be closed in finally block to release resources for test cases.
There are 4 test case use `AppStatusStore.createLiveStore` method: `AppStatusStoreSuite`, `StagePageSuite(call close in finally block)`, `AllExecutionsPageSuite(call close in after method)`, `SQLAppStatusListenerSuite(call close in after method)`, and only `AppStatusStoreSuite` has `AppStatusStore` without manual closing, so this pr has made the following changes：
- For `SPARK-36038: speculation summary should not be present if there are no speculative tasks` in `AppStatusStoreSuite`, add close `AppStatusStore` in finally block
- For `SPARK-26260: summary should contain only successful tasks' metrics (store = $hint)`, move the existing `AppStatusStore.close` to the finally block
### Why are the changes needed?
Call `AppStatusStore.close` in the finally block to release possible RocksDB resources.
### Does this PR introduce _any_ user-facing change?
NO, just for test
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #39961: [SPARK-42391][CORE][TESTS] Close live `AppStatusStore` in the finally block for test cases
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #39961:
URL: https://github.com/apache/spark/pull/39961#issuecomment-1428243610
Thanks @dongjoon-hyun @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #39961: [SPARK-42391][CORE][TESTS] Close live `AppStatusStore` in the finally block for test cases
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #39961:
URL: https://github.com/apache/spark/pull/39961#issuecomment-1427285833
cc @HyukjinKwon @dongjoon-hyun @gengliangwang @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #39961: [SPARK-42391][CORE][TESTS] Close live `AppStatusStore` in the finally block for test cases
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #39961: [SPARK-42391][CORE][TESTS] Close live `AppStatusStore` in the finally block for test cases
URL: https://github.com/apache/spark/pull/39961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39961: [SPARK-42391][CORE][TESTS] Close live `AppStatusStore` in the finally block for test cases
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39961:
URL: https://github.com/apache/spark/pull/39961#issuecomment-1427315783
Merged to master. Thank you, @LuciferYang and @srowen .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org