You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/01/14 21:16:34 UTC
[jira] Created: (HARMONY-5388) [pack200][classlib]
[pack200][classlib]
-------------------
Key: HARMONY-5388
URL: https://issues.apache.org/jira/browse/HARMONY-5388
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: All Pack200
Reporter: Andrew Cornwall
Attachments: main.patch
Pack200 bytecode offsets are not being calculated correctly when multi-instruction bytecodes are present in the bytecode stream. This causes a problem for label bytecodes which follow multi-instruction bytecodes.
In short, if you have:
<other bytecodes>
aload0_*
<other bytecodes>
if*, goto*, or jsr*
then the label of the if*, goto* or jsr* instruction will be off by the number of multi-instruction bytecodes which come before it. This will usually result in an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5388) [pack200][classlib] Label bytecode
offsets can be incorrect
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-5388.
----------------------------------
Resolution: Fixed
Thanks Andrew.
Patch applied to PACK200 module at repo revision r612054.
Please check it was applied as you expected.
> [pack200][classlib] Label bytecode offsets can be incorrect
> -----------------------------------------------------------
>
> Key: HARMONY-5388
> URL: https://issues.apache.org/jira/browse/HARMONY-5388
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All Pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: main.patch, test.patch
>
>
> Pack200 bytecode offsets are not being calculated correctly when multi-instruction bytecodes are present in the bytecode stream. This causes a problem for label bytecodes which follow multi-instruction bytecodes.
> In short, if you have:
> <other bytecodes>
> aload0_*
> <other bytecodes>
> if*, goto*, or jsr*
> then the label of the if*, goto* or jsr* instruction will be off by the number of multi-instruction bytecodes which come before it. This will usually result in an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5388) [pack200][classlib] Label bytecode
offsets can be incorrect
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison reassigned HARMONY-5388:
------------------------------------
Assignee: Tim Ellison
> [pack200][classlib] Label bytecode offsets can be incorrect
> -----------------------------------------------------------
>
> Key: HARMONY-5388
> URL: https://issues.apache.org/jira/browse/HARMONY-5388
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All Pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: main.patch, test.patch
>
>
> Pack200 bytecode offsets are not being calculated correctly when multi-instruction bytecodes are present in the bytecode stream. This causes a problem for label bytecodes which follow multi-instruction bytecodes.
> In short, if you have:
> <other bytecodes>
> aload0_*
> <other bytecodes>
> if*, goto*, or jsr*
> then the label of the if*, goto* or jsr* instruction will be off by the number of multi-instruction bytecodes which come before it. This will usually result in an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5388) [pack200][classlib] Label bytecode
offsets can be incorrect
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison closed HARMONY-5388.
--------------------------------
Verified by Andrew.
(p.s. Andrew, feel free to close the issue as you verify it -- it'll save me a step <g>, thanks)
> [pack200][classlib] Label bytecode offsets can be incorrect
> -----------------------------------------------------------
>
> Key: HARMONY-5388
> URL: https://issues.apache.org/jira/browse/HARMONY-5388
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All Pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: main.patch, test.patch
>
>
> Pack200 bytecode offsets are not being calculated correctly when multi-instruction bytecodes are present in the bytecode stream. This causes a problem for label bytecodes which follow multi-instruction bytecodes.
> In short, if you have:
> <other bytecodes>
> aload0_*
> <other bytecodes>
> if*, goto*, or jsr*
> then the label of the if*, goto* or jsr* instruction will be off by the number of multi-instruction bytecodes which come before it. This will usually result in an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5388) [pack200][classlib]
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5388:
-------------------------------------
Attachment: main.patch
The attached main.patch resolves the issue.
> [pack200][classlib]
> -------------------
>
> Key: HARMONY-5388
> URL: https://issues.apache.org/jira/browse/HARMONY-5388
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All Pack200
> Reporter: Andrew Cornwall
> Attachments: main.patch
>
>
> Pack200 bytecode offsets are not being calculated correctly when multi-instruction bytecodes are present in the bytecode stream. This causes a problem for label bytecodes which follow multi-instruction bytecodes.
> In short, if you have:
> <other bytecodes>
> aload0_*
> <other bytecodes>
> if*, goto*, or jsr*
> then the label of the if*, goto* or jsr* instruction will be off by the number of multi-instruction bytecodes which come before it. This will usually result in an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5388) [pack200][classlib] Label bytecode
offsets can be incorrect
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5388:
-------------------------------------
Summary: [pack200][classlib] Label bytecode offsets can be incorrect (was: [pack200][classlib])
> [pack200][classlib] Label bytecode offsets can be incorrect
> -----------------------------------------------------------
>
> Key: HARMONY-5388
> URL: https://issues.apache.org/jira/browse/HARMONY-5388
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All Pack200
> Reporter: Andrew Cornwall
> Attachments: main.patch
>
>
> Pack200 bytecode offsets are not being calculated correctly when multi-instruction bytecodes are present in the bytecode stream. This causes a problem for label bytecodes which follow multi-instruction bytecodes.
> In short, if you have:
> <other bytecodes>
> aload0_*
> <other bytecodes>
> if*, goto*, or jsr*
> then the label of the if*, goto* or jsr* instruction will be off by the number of multi-instruction bytecodes which come before it. This will usually result in an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5388) [pack200][classlib] Label bytecode
offsets can be incorrect
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559108#action_12559108 ]
Andrew Cornwall commented on HARMONY-5388:
------------------------------------------
Patch was applied as expected. Thanks!
> [pack200][classlib] Label bytecode offsets can be incorrect
> -----------------------------------------------------------
>
> Key: HARMONY-5388
> URL: https://issues.apache.org/jira/browse/HARMONY-5388
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All Pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: main.patch, test.patch
>
>
> Pack200 bytecode offsets are not being calculated correctly when multi-instruction bytecodes are present in the bytecode stream. This causes a problem for label bytecodes which follow multi-instruction bytecodes.
> In short, if you have:
> <other bytecodes>
> aload0_*
> <other bytecodes>
> if*, goto*, or jsr*
> then the label of the if*, goto* or jsr* instruction will be off by the number of multi-instruction bytecodes which come before it. This will usually result in an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5388) [pack200][classlib] Label bytecode
offsets can be incorrect
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5388:
-------------------------------------
Attachment: test.patch
This issue was the root cause for the failure of some JUnit tests. Now that they pass, I've reenabled those tests in the attached test.patch.
> [pack200][classlib] Label bytecode offsets can be incorrect
> -----------------------------------------------------------
>
> Key: HARMONY-5388
> URL: https://issues.apache.org/jira/browse/HARMONY-5388
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All Pack200
> Reporter: Andrew Cornwall
> Attachments: main.patch, test.patch
>
>
> Pack200 bytecode offsets are not being calculated correctly when multi-instruction bytecodes are present in the bytecode stream. This causes a problem for label bytecodes which follow multi-instruction bytecodes.
> In short, if you have:
> <other bytecodes>
> aload0_*
> <other bytecodes>
> if*, goto*, or jsr*
> then the label of the if*, goto* or jsr* instruction will be off by the number of multi-instruction bytecodes which come before it. This will usually result in an exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.