You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by eb...@apache.org on 2020/04/13 23:13:17 UTC

[tomcat-jakartaee-migration] 03/03: Publish the coverage report to Coveralls

This is an automated email from the ASF dual-hosted git repository.

ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git

commit 0502cc06283072083c2e8dd616c8a1caf1b2bb94
Author: Emmanuel Bourg <eb...@apache.org>
AuthorDate: Tue Apr 14 01:11:55 2020 +0200

    Publish the coverage report to Coveralls
---
 .travis.yml                                              | 3 +++
 pom.xml                                                  | 5 +++++
 src/main/java/org/apache/tomcat/jakartaee/Migration.java | 7 +++++--
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index eb98a0a..5364fff 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,3 +19,6 @@ jdk:
   - openjdk8
   - openjdk11
   - openjdk-ea
+
+after_success:
+  - mvn clean cobertura:cobertura coveralls:report
diff --git a/pom.xml b/pom.xml
index c094b75..2c6b3db 100644
--- a/pom.xml
+++ b/pom.xml
@@ -158,6 +158,11 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.eluder.coveralls</groupId>
+        <artifactId>coveralls-maven-plugin</artifactId>
+        <version>4.3.0</version>
+      </plugin>
     </plugins>
   </build>
 
diff --git a/src/main/java/org/apache/tomcat/jakartaee/Migration.java b/src/main/java/org/apache/tomcat/jakartaee/Migration.java
index 44efc5a..a880e63 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/Migration.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/Migration.java
@@ -238,8 +238,11 @@ public class Migration {
                 removedSignatures = true;
             }
         }
-        signatureEntries.stream()
-            .forEach(manifestAttributeEntries::remove);
+
+        for (String entry : signatureEntries) {
+            manifestAttributeEntries.remove(entry);
+        }
+
         return removedSignatures;
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org