You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/26 03:05:07 UTC
[GitHub] [rocketmq-mqtt] pingww opened a new pull request, #105: Add prehandler and fix some bugs
pingww opened a new pull request, #105:
URL: https://github.com/apache/rocketmq-mqtt/pull/105
1. Add prehandler for preprocessing on the upstream processing link
2. fix some bugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] tianliuliu merged pull request #105: Add prehandler and fix some bugs
Posted by GitBox <gi...@apache.org>.
tianliuliu merged PR #105:
URL: https://github.com/apache/rocketmq-mqtt/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #105: Add prehandler and fix some bugs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #105:
URL: https://github.com/apache/rocketmq-mqtt/pull/105#issuecomment-1138197449
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#105](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e902f0b) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/7a9adcc11ba2b0fd9b951dfbc7aca5b08cca072d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a9adcc) will **decrease** coverage by `0.45%`.
> The diff coverage is `8.33%`.
```diff
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 48.92% 48.47% -0.46%
==========================================
Files 98 98
Lines 4194 4227 +33
Branches 655 659 +4
==========================================
- Hits 2052 2049 -3
- Misses 1790 1824 +34
- Partials 352 354 +2
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/protocol/mqtt/handler/MqttDisconnectHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dERpc2Nvbm5lY3RIYW5kbGVyLmphdmE=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...mqtt/cs/protocol/mqtt/handler/MqttPingHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFBpbmdIYW5kbGVyLmphdmE=) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
| [...tt/cs/protocol/mqtt/handler/MqttPubAckHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFB1YkFja0hhbmRsZXIuamF2YQ==) | `77.77% <0.00%> (-9.73%)` | :arrow_down: |
| [...t/cs/protocol/mqtt/handler/MqttPubCompHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFB1YkNvbXBIYW5kbGVyLmphdmE=) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...tt/cs/protocol/mqtt/handler/MqttPubRecHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFB1YlJlY0hhbmRsZXIuamF2YQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...tt/cs/protocol/mqtt/handler/MqttPubRelHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFB1YlJlbEhhbmRsZXIuamF2YQ==) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
| [...t/cs/protocol/mqtt/handler/MqttPublishHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFB1Ymxpc2hIYW5kbGVyLmphdmE=) | `73.80% <0.00%> (-20.13%)` | :arrow_down: |
| [...cs/protocol/mqtt/handler/MqttSubscribeHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFN1YnNjcmliZUhhbmRsZXIuamF2YQ==) | `83.67% <0.00%> (-1.75%)` | :arrow_down: |
| [.../protocol/mqtt/handler/MqttUnSubscribeHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFVuU3Vic2NyaWJlSGFuZGxlci5qYXZh) | `78.57% <0.00%> (-2.92%)` | :arrow_down: |
| [...rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL2xvb3AvU2Vzc2lvbkxvb3BJbXBsLmphdmE=) | `44.68% <ø> (-0.18%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7a9adcc...e902f0b](https://codecov.io/gh/apache/rocketmq-mqtt/pull/105?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org