You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by setjet <gi...@git.apache.org> on 2017/04/03 21:28:36 UTC
[GitHub] spark pull request #17523: [SPARK-20064][PySpark]
GitHub user setjet opened a pull request:
https://github.com/apache/spark/pull/17523
[SPARK-20064][PySpark]
## What changes were proposed in this pull request?
PySpark version in version.py was lagging behind
Versioning is in line with PEP 440: https://www.python.org/dev/peps/pep-0440/
## How was this patch tested?
Simply rebuild the project with existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/setjet/spark SPARK-20064
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17523
----
commit a2358f7afa8502b8272a4e7caa6c64ad9f0db27d
Author: Ruben Janssen <ru...@gmail.com>
Date: 2016-07-16T15:03:19Z
added a python example for chisq selector in mllib
commit ca7cd787e174e04fbe0fcdcff26c8169450abc7b
Author: Ruben Janssen <ru...@gmail.com>
Date: 2016-08-01T18:14:01Z
updated documentation to refer to the example
commit 035aeb63ef8e8f2af8f7ed838d434a069392c336
Author: Ruben Janssen <ru...@gmail.com>
Date: 2016-10-16T15:00:44Z
updated with changes suggested by sethah
commit f49e6aea59994c471ea0270b41d5237a1f2a6a47
Author: Ruben Janssen <ru...@gmail.com>
Date: 2016-10-16T15:09:46Z
oops forgot to revert back local changes
commit a45ff2fa5e5a3633d3de24c5c2f91d59824b0fc8
Author: setjet <ru...@gmail.com>
Date: 2017-04-03T19:18:42Z
Merge remote-tracking branch 'upstream/master'
commit 8363e28e2d400c599052120153fc08eff8253cd5
Author: setjet <ru...@gmail.com>
Date: 2017-04-03T19:53:02Z
increased pyspark version
commit 881470d87d499c16cfbf6ea0a265369d60ba8f80
Author: setjet <ru...@gmail.com>
Date: 2017-04-03T21:25:37Z
Revert "oops forgot to revert back local changes"
This reverts commit f49e6aea59994c471ea0270b41d5237a1f2a6a47.
commit 09171936d5d1e9293fee6d28c44d74441a4920ab
Author: setjet <ru...@gmail.com>
Date: 2017-04-03T21:26:03Z
Revert "updated with changes suggested by sethah"
This reverts commit 035aeb63ef8e8f2af8f7ed838d434a069392c336.
commit c15654aa242d486b5eeb7e22e79915a165f6bb99
Author: setjet <ru...@gmail.com>
Date: 2017-04-03T21:26:30Z
Revert "updated documentation to refer to the example"
This reverts commit ca7cd787e174e04fbe0fcdcff26c8169450abc7b.
commit 47e4ab2cf8794718d68b5007f4980aae175eb94e
Author: setjet <ru...@gmail.com>
Date: 2017-04-03T21:26:39Z
Revert "added a python example for chisq selector in mllib"
This reverts commit a2358f7afa8502b8272a4e7caa6c64ad9f0db27d.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark] Bump the PySpark verison number t...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17523
probably need someone who can command Jenkins
(I can't)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark]
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17523
Jenkins OK to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark] Bump the PySpark verison number t...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17523
In _theory_ I can command Jenkins (the pr-status board says "asked to test" rather than "admin needed" but idk).
Lets see if Jenkins retest this please does anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark]
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17523
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark] Bump the PySpark verison number t...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17523
Thanks for your first contribution to Spark :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark]
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17523
(it would be nicer if the title is fixed to indicate what it proposes in short)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark] Bump the PySpark verison number t...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17523
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17523: [SPARK-20064][PySpark] Bump the PySpark verison n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark] Bump the PySpark verison number t...
Posted by setjet <gi...@git.apache.org>.
Github user setjet commented on the issue:
https://github.com/apache/spark/pull/17523
Done :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark]
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17523
please update the PR title
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark]
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17523
Thanks for doing this @setjet & welcome to the Spark project :) This change looks good pending jenkins, if everything passes I'll merge it tonight.
For others looking at this PR wondering, make-distribution writes its own version number when building but this version number is used for development builds so keeping it up-to-date is useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark] Bump the PySpark verison number t...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17523
not sure why Jenkins hasn't triggured. Lets try Jenkins Test This Please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark] Bump the PySpark verison number t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17523
**[Test build #3642 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3642/testReport)** for PR 17523 at commit [`47e4ab2`](https://github.com/apache/spark/commit/47e4ab2cf8794718d68b5007f4980aae175eb94e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17523: [SPARK-20064][PySpark] Bump the PySpark verison number t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17523
**[Test build #3642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3642/testReport)** for PR 17523 at commit [`47e4ab2`](https://github.com/apache/spark/commit/47e4ab2cf8794718d68b5007f4980aae175eb94e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org