You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2011/08/04 17:30:29 UTC
svn commit: r1153910 -
/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/conn/tsccm/TestConnPoolByRoute.java
Author: olegk
Date: Thu Aug 4 15:30:29 2011
New Revision: 1153910
URL: http://svn.apache.org/viewvc?rev=1153910&view=rev
Log:
Removed trailing whitespaces
Modified:
httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/conn/tsccm/TestConnPoolByRoute.java
Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/conn/tsccm/TestConnPoolByRoute.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/conn/tsccm/TestConnPoolByRoute.java?rev=1153910&r1=1153909&r2=1153910&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/conn/tsccm/TestConnPoolByRoute.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/conn/tsccm/TestConnPoolByRoute.java Thu Aug 4 15:30:29 2011
@@ -55,7 +55,7 @@ public class TestConnPoolByRoute extends
private ConnPoolByRoute impl;
private HttpRoute route = new HttpRoute(new HttpHost("localhost"));
private HttpRoute route2 = new HttpRoute(new HttpHost("localhost:8080"));
-
+
@Mock private OperatedClientConnection mockConnection;
@Mock private OperatedClientConnection mockConnection2;
@Mock private ClientConnectionOperator mockOperator;
@@ -68,7 +68,7 @@ public class TestConnPoolByRoute extends
new DefaultClientConnectionOperator(supportedSchemes),
new ConnPerRouteBean(), 1, -1, TimeUnit.MILLISECONDS);
}
-
+
private void useMockOperator() {
reset(mockOperator);
impl = new ConnPoolByRoute(
@@ -188,62 +188,62 @@ public class TestConnPoolByRoute extends
connPool.shutdown();
}
}
-
+
@Test(expected=IllegalArgumentException.class)
public void nullOperatorIsNotAllowed() {
new ConnPoolByRoute(null, new ConnPerRouteBean(), 1, -1, TimeUnit.MILLISECONDS);
}
-
+
@Test(expected=IllegalArgumentException.class)
public void nullConnPerRouteIsNotAllowed() {
new ConnPoolByRoute(new DefaultClientConnectionOperator(supportedSchemes),
null, 1, -1, TimeUnit.MILLISECONDS);
}
-
+
@Test
@SuppressWarnings("deprecation")
public void deprecatedConstructorIsStillSupported() {
new ConnPoolByRoute(new DefaultClientConnectionOperator(supportedSchemes),
new BasicHttpParams());
}
-
+
@Test
public void emptyPoolHasNoConnections() {
assertEquals(0, impl.getConnectionsInPool());
}
-
+
@Test
public void poolHasOneConnectionAfterRequestingOne() throws Exception {
useMockOperator();
impl.requestPoolEntry(route, new Object()).getPoolEntry(-1, TimeUnit.MILLISECONDS);
assertEquals(1, impl.getConnectionsInPool());
}
-
+
@Test
public void emptyPoolHasNoRouteSpecificConnections() {
assertEquals(0, impl.getConnectionsInPool(route));
}
-
+
@Test
public void routeSpecificPoolHasOneConnectionAfterRequestingOne() throws Exception {
useMockOperator();
impl.requestPoolEntry(route, new Object()).getPoolEntry(-1, TimeUnit.MILLISECONDS);
assertEquals(1, impl.getConnectionsInPool(route));
}
-
+
@Test
public void abortingPoolEntryRequestEarlyDoesNotCreateConnection() {
PoolEntryRequest req = impl.requestPoolEntry(route, new Object());
req.abortRequest();
assertEquals(0, impl.getConnectionsInPool(route));
}
-
+
@Test(expected=IllegalStateException.class)
public void cannotAcquireConnectionIfPoolShutdown() throws Exception {
impl.shutdown();
impl.requestPoolEntry(route, new Object()).getPoolEntry(-1, TimeUnit.MILLISECONDS);
}
-
+
@Test
public void multipleShutdownsAreOk() {
impl.shutdown();
@@ -254,14 +254,14 @@ public class TestConnPoolByRoute extends
public void canAcquirePoolEntry() throws Exception {
impl.requestPoolEntry(route, new Object()).getPoolEntry(-1, TimeUnit.MILLISECONDS);
}
-
+
@Test
public void canRetrieveMaxTotalConnections() {
int max = (new Random()).nextInt(10) + 2;
impl.setMaxTotalConnections(max);
assertEquals(max, impl.getMaxTotalConnections());
}
-
+
@Test
public void closesFreedConnectionsWhenShutdown() throws Exception {
useMockOperator();
@@ -270,7 +270,7 @@ public class TestConnPoolByRoute extends
impl.freeEntry(entry, true, Long.MAX_VALUE, TimeUnit.MILLISECONDS);
verify(mockConnection, atLeastOnce()).close();
}
-
+
@Test
public void deleteClosedConnectionsReclaimsPoolSpace() throws Exception {
useMockOperator();
@@ -282,7 +282,7 @@ public class TestConnPoolByRoute extends
assertTrue(impl.freeConnections.isEmpty());
assertEquals(0, impl.numConnections);
}
-
+
@Test
public void deleteClosedConnectionsDoesNotReclaimOpenConnections() throws Exception {
useMockOperator();
@@ -294,7 +294,7 @@ public class TestConnPoolByRoute extends
assertFalse(impl.freeConnections.isEmpty());
assertEquals(1, impl.numConnections);
}
-
+
@Test
public void closeIdleConnectionsClosesThoseThatHaveTimedOut() throws Exception {
useMockOperator();
@@ -302,9 +302,9 @@ public class TestConnPoolByRoute extends
impl.freeEntry(entry, true, Long.MAX_VALUE, TimeUnit.MILLISECONDS);
Thread.sleep(2);
impl.closeIdleConnections(1, TimeUnit.MILLISECONDS);
- verify(mockConnection, atLeastOnce()).close();
+ verify(mockConnection, atLeastOnce()).close();
}
-
+
@Test
public void closeIdleConnectionsDoesNotCloseThoseThatHaveNotTimedOut() throws Exception {
useMockOperator();
@@ -312,7 +312,7 @@ public class TestConnPoolByRoute extends
impl.freeEntry(entry, true, Long.MAX_VALUE, TimeUnit.MILLISECONDS);
Thread.sleep(1);
impl.closeIdleConnections(3, TimeUnit.MILLISECONDS);
- verify(mockConnection, never()).close();
+ verify(mockConnection, never()).close();
}
@Test
@@ -322,7 +322,7 @@ public class TestConnPoolByRoute extends
impl.freeEntry(entry, true, 1, TimeUnit.MILLISECONDS);
Thread.sleep(2);
impl.closeExpiredConnections();
- verify(mockConnection, atLeastOnce()).close();
+ verify(mockConnection, atLeastOnce()).close();
}
@Test
@@ -332,7 +332,7 @@ public class TestConnPoolByRoute extends
impl.freeEntry(entry, true, 10, TimeUnit.MILLISECONDS);
Thread.sleep(1);
impl.closeExpiredConnections();
- verify(mockConnection, never()).close();
+ verify(mockConnection, never()).close();
}
@Test
@@ -340,9 +340,9 @@ public class TestConnPoolByRoute extends
useMockOperator();
BasicPoolEntry entry = impl.requestPoolEntry(route, new Object()).getPoolEntry(-1, TimeUnit.MILLISECONDS);
impl.freeEntry(entry, false, 0, TimeUnit.MILLISECONDS);
- verify(mockConnection, atLeastOnce()).close();
+ verify(mockConnection, atLeastOnce()).close();
}
-
+
@Test
public void handlesExceptionsWhenClosingConnections() throws Exception {
useMockOperator();
@@ -374,7 +374,7 @@ public class TestConnPoolByRoute extends
Thread.sleep(5);
assertTrue(f.flag);
}
-
+
@Test
public void wakesUpWaitingThreadsOnOtherRoutesWhenEntryAvailable() throws Exception {
useMockOperator();
@@ -398,7 +398,7 @@ public class TestConnPoolByRoute extends
Thread.sleep(5);
assertTrue(f.flag);
}
-
+
@Test
public void doesNotRecycleExpiredConnections() throws Exception {
useMockOperator();
@@ -409,7 +409,7 @@ public class TestConnPoolByRoute extends
BasicPoolEntry entry2 = impl.requestPoolEntry(route, new Object()).getPoolEntry(-1, TimeUnit.MILLISECONDS);
assertNotSame(mockConnection, entry2.getConnection());
}
-
+
@Test
public void closesExpiredConnectionsWhenNotReusingThem() throws Exception {
useMockOperator();
@@ -421,7 +421,7 @@ public class TestConnPoolByRoute extends
verify(mockConnection, atLeastOnce()).close();
}
-
+
@Test
public void wakesUpWaitingThreadsOnShutdown() throws Exception {
useMockOperator();