[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4128: nuttx net warning:add initialization of pointer *aiocbp in lio_listio

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #4128:
URL: https://github.com/apache/incubator-nuttx/pull/4128#discussion_r667893896



##########
File path: libs/libc/aio/lio_listio.c
##########
@@ -507,7 +507,7 @@ static int lio_waitall(FAR struct aiocb * const *list, int nent)
 int lio_listio(int mode, FAR struct aiocb * const list[], int nent,
                FAR struct sigevent *sig)
 {
-  FAR struct aiocb *aiocbp;
+  FAR struct aiocb *aiocbp = NULL;

Review comment:
       Could you point out the rule? There are many many places initialize the variables directly.

##########
File path: libs/libc/debug/lib_backtrace.c
##########
@@ -44,7 +44,7 @@ struct trace_arg
  * Private Functions
  ****************************************************************************/
 
-static inline weak_function
+weak_function

Review comment:
       Done, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org