You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/18 02:57:01 UTC
[GitHub] [dubbo] EarthChen opened a new pull request #9057: [3.0-Triple] Refactor transport state and other code
EarthChen opened a new pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057
## What is the purpose of the change
- add transport state for stream and remove check in transport
- optimize some code
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34fe157) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.07%`.
> The diff coverage is `54.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.20% -0.08%
+ Complexity 314 313 -1
============================================
Files 1169 1170 +1
Lines 50219 50218 -1
Branches 7466 7448 -18
============================================
- Hits 32279 32243 -36
- Misses 14434 14452 +18
- Partials 3506 3523 +17
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `54.25% <33.33%> (-3.07%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `41.83% <33.33%> (-0.58%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.42% <44.00%> (-3.51%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <59.09%> (+14.05%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `61.29% <60.00%> (-8.98%)` | :arrow_down: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TransportState.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0U3RhdGUuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...34fe157](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e597a1) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.04%`.
> The diff coverage is `55.00%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.23% -0.05%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50656 +437
Branches 7466 7533 +67
============================================
+ Hits 32279 32538 +259
- Misses 14434 14568 +134
- Partials 3506 3550 +44
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.40% <33.33%> (ø)` | |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `54.16% <47.36%> (-3.16%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <59.09%> (+14.05%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `69.44% <65.62%> (-0.83%)` | :arrow_down: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TransportState.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0U3RhdGUuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| ... and [117 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...1e597a1](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (38b9d96) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.04%`.
> The diff coverage is `56.36%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.23% -0.05%
+ Complexity 314 313 -1
============================================
Files 1169 1170 +1
Lines 50219 50203 -16
Branches 7466 7446 -20
============================================
- Hits 32279 32247 -32
+ Misses 14434 14432 -2
- Partials 3506 3524 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ubbo/rpc/protocol/tri/ServerTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyVHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `68.75% <ø> (+3.63%)` | :arrow_up: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.42% <44.00%> (-3.51%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `41.83% <44.44%> (-0.58%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <59.09%> (+14.05%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `64.28% <65.38%> (-5.99%)` | :arrow_down: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TransportState.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0U3RhdGUuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| ... and [42 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...38b9d96](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e356462) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.01%`.
> The diff coverage is `52.09%`.
> :exclamation: Current head e356462 differs from pull request most recent head d4c21f7. Consider uploading reports for the commit d4c21f7 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.25% -0.02%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50726 +507
Branches 7466 7549 +83
============================================
+ Hits 32279 32596 +317
- Misses 14434 14580 +146
- Partials 3506 3550 +44
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/dubbo/rpc/model/MethodDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTWV0aG9kRGVzY3JpcHRvci5qYXZh) | `76.12% <0.00%> (-7.97%)` | :arrow_down: |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `30.95% <22.22%> (-8.53%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| ... and [137 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...d4c21f7](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74a29bb) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.04%`.
> The diff coverage is `55.39%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.23% -0.05%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50687 +468
Branches 7466 7539 +73
============================================
+ Hits 32279 32557 +278
- Misses 14434 14580 +146
- Partials 3506 3550 +44
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `62.50% <66.66%> (-0.36%)` | :arrow_down: |
| ... and [122 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...74a29bb](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c21d09a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.09%`.
> The diff coverage is `52.24%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.18% -0.10%
- Complexity 314 320 +6
============================================
Files 1169 1177 +8
Lines 50219 50742 +523
Branches 7466 7550 +84
============================================
+ Hits 32279 32569 +290
- Misses 14434 14610 +176
- Partials 3506 3563 +57
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/dubbo/rpc/model/MethodDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTWV0aG9kRGVzY3JpcHRvci5qYXZh) | `76.12% <0.00%> (-7.97%)` | :arrow_down: |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `30.95% <22.22%> (-8.53%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| ... and [140 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...c21d09a](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (428be69) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.19%`.
> The diff coverage is `55.52%`.
> :exclamation: Current head 428be69 differs from pull request most recent head 667bce6. Consider uploading reports for the commit 667bce6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.08% -0.20%
- Complexity 314 322 +8
============================================
Files 1169 1177 +8
Lines 50219 50645 +426
Branches 7466 7511 +45
============================================
+ Hits 32279 32455 +176
- Misses 14434 14621 +187
- Partials 3506 3569 +63
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `66.66% <80.00%> (+3.80%)` | :arrow_up: |
| ... and [137 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...667bce6](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (428be69) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.15%`.
> The diff coverage is `55.52%`.
> :exclamation: Current head 428be69 differs from pull request most recent head 667bce6. Consider uploading reports for the commit 667bce6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.11% -0.16%
- Complexity 314 322 +8
============================================
Files 1169 1177 +8
Lines 50219 50680 +461
Branches 7466 7538 +72
============================================
+ Hits 32279 32496 +217
- Misses 14434 14624 +190
- Partials 3506 3560 +54
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `66.66% <80.00%> (+3.80%)` | :arrow_up: |
| ... and [116 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...667bce6](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c3af07) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.04%`.
> The diff coverage is `55.23%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.22% -0.05%
+ Complexity 314 311 -3
============================================
Files 1169 1170 +1
Lines 50219 50201 -18
Branches 7466 7446 -20
============================================
- Hits 32279 32244 -35
- Misses 14434 14435 +1
- Partials 3506 3522 +16
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `41.83% <33.33%> (-0.58%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.42% <44.00%> (-3.51%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <59.09%> (+14.05%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `64.28% <65.38%> (-5.99%)` | :arrow_down: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TransportState.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0U3RhdGUuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| [.../apache/dubbo/rpc/protocol/tri/TripleConstant.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ29uc3RhbnQuamF2YQ==) | `91.66% <91.66%> (-8.34%)` | :arrow_down: |
| ... and [48 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...8c3af07](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao commented on a change in pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
guohao commented on a change in pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#discussion_r732373208
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ClientTransportObserver.java
##########
@@ -20,62 +20,35 @@
import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelPromise;
-import io.netty.handler.codec.http.HttpMethod;
import io.netty.handler.codec.http2.DefaultHttp2DataFrame;
import io.netty.handler.codec.http2.DefaultHttp2Headers;
import io.netty.handler.codec.http2.DefaultHttp2HeadersFrame;
import io.netty.handler.codec.http2.DefaultHttp2ResetFrame;
import io.netty.handler.codec.http2.Http2Error;
import io.netty.handler.codec.http2.Http2Headers;
import io.netty.handler.codec.http2.Http2StreamChannel;
-import io.netty.handler.codec.http2.Http2StreamChannelBootstrap;
-import io.netty.util.AsciiString;
public class ClientTransportObserver implements TransportObserver {
- private final AsciiString SCHEME;
private final ChannelHandlerContext ctx;
- private final Http2StreamChannel streamChannel;
private final ChannelPromise promise;
- private boolean headerSent = false;
- private boolean endStreamSent = false;
- private boolean resetSent = false;
+ private volatile Http2StreamChannel streamChannel;
+ public void setStreamChannel(Http2StreamChannel streamChannel) {
+ this.streamChannel = streamChannel;
+ }
- public ClientTransportObserver(ChannelHandlerContext ctx, AbstractClientStream stream, ChannelPromise promise) {
+ public ClientTransportObserver(ChannelHandlerContext ctx, ChannelPromise promise) {
this.ctx = ctx;
this.promise = promise;
- Boolean ssl = ctx.channel().attr(TripleConstant.SSL_ATTRIBUTE_KEY).get();
- if (ssl != null && ssl) {
- SCHEME = TripleConstant.HTTPS_SCHEME;
- } else {
- SCHEME = TripleConstant.HTTP_SCHEME;
- }
-
- final Http2StreamChannelBootstrap streamChannelBootstrap = new Http2StreamChannelBootstrap(ctx.channel());
- streamChannel = streamChannelBootstrap.open().syncUninterruptibly().getNow();
-
- final TripleHttp2ClientResponseHandler responseHandler = new TripleHttp2ClientResponseHandler();
- streamChannel.pipeline().addLast(responseHandler)
- .addLast(new GrpcDataDecoder(Integer.MAX_VALUE, true))
- .addLast(new TripleClientInboundHandler());
- streamChannel.attr(TripleConstant.CLIENT_STREAM_KEY).set(stream);
}
@Override
public void onMetadata(Metadata metadata, boolean endStream) {
- if (headerSent) {
- return;
+ while (streamChannel == null) {
+ // wait channel initialized
Review comment:
streamChannel may be null if `open` failed, and will be blocked here forever
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -18,34 +18,58 @@
package org.apache.dubbo.rpc.protocol.tri;
import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.config.ConfigurationUtils;
import org.apache.dubbo.common.constants.CommonConstants;
+import org.apache.dubbo.common.stream.StreamObserver;
+import org.apache.dubbo.common.utils.CollectionUtils;
+import org.apache.dubbo.remoting.Constants;
import org.apache.dubbo.remoting.api.Connection;
+import org.apache.dubbo.remoting.exchange.Request;
import org.apache.dubbo.remoting.exchange.support.DefaultFuture2;
import org.apache.dubbo.rpc.CancellationContext;
import org.apache.dubbo.rpc.RpcInvocation;
import org.apache.dubbo.rpc.model.ConsumerModel;
+import org.apache.dubbo.rpc.model.MethodDescriptor;
+import org.apache.dubbo.rpc.model.ServiceModel;
import org.apache.dubbo.triple.TripleWrapper;
import io.netty.handler.codec.http.HttpHeaderNames;
import io.netty.handler.codec.http.HttpHeaderValues;
+import io.netty.handler.codec.http.HttpMethod;
import io.netty.handler.codec.http2.Http2Error;
+import io.netty.handler.codec.http2.Http2Headers;
+import io.netty.util.AsciiString;
+import java.util.Arrays;
+import java.util.List;
import java.util.Map;
-import java.util.concurrent.Executor;
import java.util.concurrent.RejectedExecutionException;
+import static org.apache.dubbo.rpc.Constants.COMPRESSOR_KEY;
+import static org.apache.dubbo.rpc.protocol.tri.Compressor.DEFAULT_COMPRESSOR;
+
public abstract class AbstractClientStream extends AbstractStream implements Stream {
+
+ private final AsciiString scheme;
private ConsumerModel consumerModel;
private Connection connection;
+ private RpcInvocation rpcInvocation;
+ private long requestId;
protected AbstractClientStream(URL url) {
super(url);
+ this.scheme = getSchemeFromUrl(url);
+ // for client cancel,send rst frame to server
+ this.getCancellationContext().addListener(context -> {
+ Throwable throwable = this.getCancellationContext().getCancellationCause();
+ if (LOGGER.isWarnEnabled()) {
+ LOGGER.warn("Cancel by local throwable is ", throwable);
Review comment:
```suggestion
LOGGER.warn("Triple request to {service+method} was canceled by local exception ", throwable);
```
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -55,38 +79,107 @@ public static ClientStream stream(URL url) {
return new ClientStream(url);
}
- public static AbstractClientStream newClientStream(URL url, boolean unary) {
- AbstractClientStream stream = unary ? unary(url) : stream(url);
- final CancellationContext cancellationContext = stream.getCancellationContext();
- // for client cancel,send rst frame to server
- cancellationContext.addListener(context -> {
- if (LOGGER.isWarnEnabled()) {
- Throwable throwable = cancellationContext.getCancellationCause();
- LOGGER.warn("Cancel by local throwable is ", throwable);
- }
- stream.asTransportObserver().onReset(Http2Error.CANCEL);
- });
+ public static AbstractClientStream newClientStream(Request req, Connection connection) {
+ final RpcInvocation inv = (RpcInvocation) req.getData();
+ final URL url = inv.getInvoker().getUrl();
+ ConsumerModel consumerModel = inv.getServiceModel() != null ? (ConsumerModel) inv.getServiceModel() : (ConsumerModel) url.getServiceModel();
+ MethodDescriptor methodDescriptor = getTriMethodDescriptor(consumerModel, inv);
+ ClassLoadUtil.switchContextLoader(consumerModel.getClassLoader());
+ AbstractClientStream stream = methodDescriptor.isUnary() ? unary(url) : stream(url);
+ Compressor compressor = getCompressor(url, consumerModel);
+ stream.request(req)
+ .service(consumerModel)
+ .connection(connection)
+ .serialize((String) inv.getObjectAttachment(Constants.SERIALIZATION_KEY))
+ .method(methodDescriptor)
+ .setCompressor(compressor)
+ ;
Review comment:
fix format
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ClientTransportObserver.java
##########
@@ -20,62 +20,35 @@
import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelPromise;
-import io.netty.handler.codec.http.HttpMethod;
import io.netty.handler.codec.http2.DefaultHttp2DataFrame;
import io.netty.handler.codec.http2.DefaultHttp2Headers;
import io.netty.handler.codec.http2.DefaultHttp2HeadersFrame;
import io.netty.handler.codec.http2.DefaultHttp2ResetFrame;
import io.netty.handler.codec.http2.Http2Error;
import io.netty.handler.codec.http2.Http2Headers;
import io.netty.handler.codec.http2.Http2StreamChannel;
-import io.netty.handler.codec.http2.Http2StreamChannelBootstrap;
-import io.netty.util.AsciiString;
public class ClientTransportObserver implements TransportObserver {
- private final AsciiString SCHEME;
private final ChannelHandlerContext ctx;
- private final Http2StreamChannel streamChannel;
private final ChannelPromise promise;
- private boolean headerSent = false;
- private boolean endStreamSent = false;
- private boolean resetSent = false;
+ private volatile Http2StreamChannel streamChannel;
+ public void setStreamChannel(Http2StreamChannel streamChannel) {
+ this.streamChannel = streamChannel;
+ }
- public ClientTransportObserver(ChannelHandlerContext ctx, AbstractClientStream stream, ChannelPromise promise) {
+ public ClientTransportObserver(ChannelHandlerContext ctx, ChannelPromise promise) {
this.ctx = ctx;
this.promise = promise;
- Boolean ssl = ctx.channel().attr(TripleConstant.SSL_ATTRIBUTE_KEY).get();
- if (ssl != null && ssl) {
- SCHEME = TripleConstant.HTTPS_SCHEME;
- } else {
- SCHEME = TripleConstant.HTTP_SCHEME;
- }
-
- final Http2StreamChannelBootstrap streamChannelBootstrap = new Http2StreamChannelBootstrap(ctx.channel());
- streamChannel = streamChannelBootstrap.open().syncUninterruptibly().getNow();
-
- final TripleHttp2ClientResponseHandler responseHandler = new TripleHttp2ClientResponseHandler();
- streamChannel.pipeline().addLast(responseHandler)
- .addLast(new GrpcDataDecoder(Integer.MAX_VALUE, true))
- .addLast(new TripleClientInboundHandler());
- streamChannel.attr(TripleConstant.CLIENT_STREAM_KEY).set(stream);
}
@Override
public void onMetadata(Metadata metadata, boolean endStream) {
- if (headerSent) {
- return;
+ while (streamChannel == null) {
+ // wait channel initialized
Review comment:
How about using async send after channel created
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -55,38 +79,107 @@ public static ClientStream stream(URL url) {
return new ClientStream(url);
}
- public static AbstractClientStream newClientStream(URL url, boolean unary) {
- AbstractClientStream stream = unary ? unary(url) : stream(url);
- final CancellationContext cancellationContext = stream.getCancellationContext();
- // for client cancel,send rst frame to server
- cancellationContext.addListener(context -> {
- if (LOGGER.isWarnEnabled()) {
- Throwable throwable = cancellationContext.getCancellationCause();
- LOGGER.warn("Cancel by local throwable is ", throwable);
- }
- stream.asTransportObserver().onReset(Http2Error.CANCEL);
- });
+ public static AbstractClientStream newClientStream(Request req, Connection connection) {
+ final RpcInvocation inv = (RpcInvocation) req.getData();
+ final URL url = inv.getInvoker().getUrl();
+ ConsumerModel consumerModel = inv.getServiceModel() != null ? (ConsumerModel) inv.getServiceModel() : (ConsumerModel) url.getServiceModel();
+ MethodDescriptor methodDescriptor = getTriMethodDescriptor(consumerModel, inv);
+ ClassLoadUtil.switchContextLoader(consumerModel.getClassLoader());
+ AbstractClientStream stream = methodDescriptor.isUnary() ? unary(url) : stream(url);
+ Compressor compressor = getCompressor(url, consumerModel);
+ stream.request(req)
+ .service(consumerModel)
+ .connection(connection)
+ .serialize((String) inv.getObjectAttachment(Constants.SERIALIZATION_KEY))
+ .method(methodDescriptor)
+ .setCompressor(compressor)
+ ;
return stream;
}
- public AbstractClientStream service(ConsumerModel model) {
- this.consumerModel = model;
- return this;
+ protected void startCall() {
+ try {
+ doOnStartCall();
+ } catch (Throwable throwable) {
+ cancel(throwable);
+ DefaultFuture2.getFuture(getRequestId()).cancel();
+ }
}
- public ConsumerModel getConsumerModel() {
- return consumerModel;
+ protected abstract void doOnStartCall();
+
+ @Override
+ protected StreamObserver<Object> createStreamObserver() {
+ return new ClientStreamObserverImpl(getCancellationContext());
}
- public AbstractClientStream connection(Connection connection) {
- this.connection = connection;
- return this;
+ protected class ClientStreamObserverImpl extends CancelableStreamObserver<Object> implements ClientStreamObserver<Object> {
+
+ public ClientStreamObserverImpl(CancellationContext cancellationContext) {
+ super(cancellationContext);
+ }
+
+ @Override
+ public void onNext(Object data) {
+ if (getState().allowSendMeta()) {
+ getState().setMetaSend();
+ final Metadata metadata = createRequestMeta(getRpcInvocation());
+ getTransportSubscriber().onMetadata(metadata, false);
+ }
+ if (getState().allowSendData()) {
+ final byte[] bytes = encodeRequest(data);
+ getTransportSubscriber().onData(bytes, false);
+ }
+ }
+
+ /**
+ * Handle all exceptions in the request process, other procedures directly throw
+ * <p>
+ * other procedures is {@link ClientStreamObserver#onNext(Object)} and {@link ClientStreamObserver#onCompleted()}
+ */
+ @Override
+ public void onError(Throwable throwable) {
+ if (getState().allowSendEndStream()) {
+ getState().setEndStreamSend();
+ GrpcStatus status = GrpcStatus.getStatus(throwable);
+ transportError(status, null, getState().allowSendMeta());
+ } else {
+ if (LOGGER.isErrorEnabled()) {
+ LOGGER.error("client request error ", throwable);
Review comment:
Add service and method descriprtion to log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1aac40) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.04%`.
> The diff coverage is `55.39%`.
> :exclamation: Current head c1aac40 differs from pull request most recent head 667bce6. Consider uploading reports for the commit 667bce6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.23% -0.05%
- Complexity 314 321 +7
============================================
Files 1169 1177 +8
Lines 50219 50687 +468
Branches 7466 7539 +73
============================================
+ Hits 32279 32559 +280
- Misses 14434 14573 +139
- Partials 3506 3555 +49
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `62.50% <66.66%> (-0.36%)` | :arrow_down: |
| ... and [122 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...667bce6](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd122ea) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.04%`.
> The diff coverage is `52.37%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.22% -0.05%
- Complexity 314 320 +6
============================================
Files 1169 1178 +9
Lines 50219 50726 +507
Branches 7466 7539 +73
============================================
+ Hits 32279 32581 +302
- Misses 14434 14586 +152
- Partials 3506 3559 +53
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| ... and [130 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...bd122ea](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao merged pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
guohao merged pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c3af07) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **increase** coverage by `0.00%`.
> The diff coverage is `55.23%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
=========================================
Coverage 64.27% 64.28%
Complexity 314 314
=========================================
Files 1169 1170 +1
Lines 50219 50236 +17
Branches 7466 7473 +7
=========================================
+ Hits 32279 32294 +15
+ Misses 14434 14430 -4
- Partials 3506 3512 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `41.83% <33.33%> (-0.58%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.42% <44.00%> (-3.51%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <59.09%> (+14.05%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `64.28% <65.38%> (-5.99%)` | :arrow_down: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TransportState.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0U3RhdGUuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| [.../apache/dubbo/rpc/protocol/tri/TripleConstant.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ29uc3RhbnQuamF2YQ==) | `91.66% <91.66%> (-8.34%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...8c3af07](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74a29bb) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.20%`.
> The diff coverage is `55.39%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.07% -0.21%
- Complexity 314 322 +8
============================================
Files 1169 1177 +8
Lines 50219 50652 +433
Branches 7466 7512 +46
============================================
+ Hits 32279 32453 +174
- Misses 14434 14630 +196
- Partials 3506 3569 +63
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `62.50% <66.66%> (-0.36%)` | :arrow_down: |
| ... and [135 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...74a29bb](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd122ea) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.21%`.
> The diff coverage is `52.37%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.05% -0.22%
- Complexity 314 320 +6
============================================
Files 1169 1178 +9
Lines 50219 50726 +507
Branches 7466 7517 +51
============================================
+ Hits 32279 32495 +216
- Misses 14434 14655 +221
- Partials 3506 3576 +70
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| ... and [133 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...bd122ea](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5af8ca) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.10%`.
> The diff coverage is `52.56%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.17% -0.11%
- Complexity 314 322 +8
============================================
Files 1169 1177 +8
Lines 50219 50690 +471
Branches 7466 7512 +46
============================================
+ Hits 32279 32531 +252
- Misses 14434 14598 +164
- Partials 3506 3561 +55
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| ... and [145 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...e5af8ca](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on a change in pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
EarthChen commented on a change in pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#discussion_r732385483
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ClientTransportObserver.java
##########
@@ -20,62 +20,35 @@
import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelPromise;
-import io.netty.handler.codec.http.HttpMethod;
import io.netty.handler.codec.http2.DefaultHttp2DataFrame;
import io.netty.handler.codec.http2.DefaultHttp2Headers;
import io.netty.handler.codec.http2.DefaultHttp2HeadersFrame;
import io.netty.handler.codec.http2.DefaultHttp2ResetFrame;
import io.netty.handler.codec.http2.Http2Error;
import io.netty.handler.codec.http2.Http2Headers;
import io.netty.handler.codec.http2.Http2StreamChannel;
-import io.netty.handler.codec.http2.Http2StreamChannelBootstrap;
-import io.netty.util.AsciiString;
public class ClientTransportObserver implements TransportObserver {
- private final AsciiString SCHEME;
private final ChannelHandlerContext ctx;
- private final Http2StreamChannel streamChannel;
private final ChannelPromise promise;
- private boolean headerSent = false;
- private boolean endStreamSent = false;
- private boolean resetSent = false;
+ private volatile Http2StreamChannel streamChannel;
+ public void setStreamChannel(Http2StreamChannel streamChannel) {
+ this.streamChannel = streamChannel;
+ }
- public ClientTransportObserver(ChannelHandlerContext ctx, AbstractClientStream stream, ChannelPromise promise) {
+ public ClientTransportObserver(ChannelHandlerContext ctx, ChannelPromise promise) {
this.ctx = ctx;
this.promise = promise;
- Boolean ssl = ctx.channel().attr(TripleConstant.SSL_ATTRIBUTE_KEY).get();
- if (ssl != null && ssl) {
- SCHEME = TripleConstant.HTTPS_SCHEME;
- } else {
- SCHEME = TripleConstant.HTTP_SCHEME;
- }
-
- final Http2StreamChannelBootstrap streamChannelBootstrap = new Http2StreamChannelBootstrap(ctx.channel());
- streamChannel = streamChannelBootstrap.open().syncUninterruptibly().getNow();
-
- final TripleHttp2ClientResponseHandler responseHandler = new TripleHttp2ClientResponseHandler();
- streamChannel.pipeline().addLast(responseHandler)
- .addLast(new GrpcDataDecoder(Integer.MAX_VALUE, true))
- .addLast(new TripleClientInboundHandler());
- streamChannel.attr(TripleConstant.CLIENT_STREAM_KEY).set(stream);
}
@Override
public void onMetadata(Metadata metadata, boolean endStream) {
- if (headerSent) {
- return;
+ while (streamChannel == null) {
+ // wait channel initialized
Review comment:
Change the next PR to send using a queue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e597a1) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.07%`.
> The diff coverage is `55.00%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.19% -0.08%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50656 +437
Branches 7466 7533 +67
============================================
+ Hits 32279 32520 +241
- Misses 14434 14584 +150
- Partials 3506 3552 +46
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.40% <33.33%> (ø)` | |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `54.16% <47.36%> (-3.16%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <59.09%> (+14.05%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `69.44% <65.62%> (-0.83%)` | :arrow_down: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TransportState.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0U3RhdGUuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| ... and [118 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...1e597a1](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao commented on a change in pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
guohao commented on a change in pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#discussion_r730564516
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ClientTransportObserver.java
##########
@@ -34,11 +34,13 @@
public class ClientTransportObserver implements TransportObserver {
private final AsciiString SCHEME;
private final ChannelHandlerContext ctx;
- private final Http2StreamChannel streamChannel;
+ private volatile Http2StreamChannel streamChannel;
private final ChannelPromise promise;
- private boolean headerSent = false;
- private boolean endStreamSent = false;
- private boolean resetSent = false;
+// private boolean headerSent = false;
Review comment:
Remove unused fileds
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractServerStream.java
##########
@@ -134,7 +137,7 @@ protected RpcInvocation buildInvocation(Metadata metadata) {
ClassLoader tccl = Thread.currentThread().getContextClassLoader();
try {
if (getProviderModel() != null) {
- ClassLoadUtil.switchContextLoader(getProviderModel().getClassLoader());
+ ClassLoadUtil.switchContextLoader(getProviderModel().getServiceInterfaceClass().getClassLoader());
Review comment:
What is the difference bwteen `model.getClassLoader()` and service interface classloader ?
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ServerTransportObserver.java
##########
@@ -28,34 +28,32 @@
import io.netty.handler.codec.http2.DefaultHttp2ResetFrame;
import io.netty.handler.codec.http2.Http2Error;
-import static io.netty.handler.codec.http.HttpResponseStatus.OK;
-
public class ServerTransportObserver implements TransportObserver {
private static final Logger LOGGER = LoggerFactory.getLogger(ServerTransportObserver.class);
private final ChannelHandlerContext ctx;
- private boolean headerSent = false;
- private boolean resetSent = false;
+// private boolean headerSent = false;
Review comment:
Remove these unused code
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -194,4 +211,23 @@ protected void cancelByLocal(Throwable throwable) {
}
+ protected abstract class AbstractClientTransport extends AbstractTransportObserver {
+
+ @Override
+ public void onData(byte[] data, boolean endStream) {
+ execute(() -> {
+ final Object resp = deserializeResponse(data);
+ getStreamSubscriber().onNext(resp);
+ });
+ }
+
+// protected abstract
Review comment:
Fix
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/UnaryClientStream.java
##########
@@ -40,10 +38,16 @@ protected UnaryClientStream(URL url) {
}
@Override
- protected StreamObserver<Object> createStreamObserver() {
- return new UnaryClientStreamObserverImpl();
+ protected void doOnStartCall() {
+ asStreamObserver().onNext(getRpcInvocation());
+ asStreamObserver().onCompleted();
}
+// @Override
Review comment:
Remove these
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java
##########
@@ -69,11 +72,40 @@ public static AbstractClientStream newClientStream(URL url, boolean unary) {
return stream;
}
+ protected RpcInvocation getRpcInvocation() {
+ return (RpcInvocation) getRequest().getData();
+ }
+
+ protected void startCall() {
+ try {
+ doOnStartCall();
+ } catch (Throwable throwable) {
+ asStreamObserver().onError(throwable);
Review comment:
Client shoulde not send error to server if exception occurred in sending request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (428be69) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.04%`.
> The diff coverage is `55.52%`.
> :exclamation: Current head 428be69 differs from pull request most recent head 667bce6. Consider uploading reports for the commit 667bce6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.23% -0.05%
- Complexity 314 322 +8
============================================
Files 1169 1177 +8
Lines 50219 50680 +461
Branches 7466 7538 +72
============================================
+ Hits 32279 32555 +276
- Misses 14434 14576 +142
- Partials 3506 3549 +43
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `66.66% <80.00%> (+3.80%)` | :arrow_up: |
| ... and [121 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...667bce6](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5af8ca) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.05%`.
> The diff coverage is `52.56%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.22% -0.06%
- Complexity 314 322 +8
============================================
Files 1169 1177 +8
Lines 50219 50725 +506
Branches 7466 7539 +73
============================================
+ Hits 32279 32578 +299
- Misses 14434 14589 +155
- Partials 3506 3558 +52
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| ... and [129 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...e5af8ca](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74a29bb) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.02%`.
> The diff coverage is `55.39%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.25% -0.03%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50687 +468
Branches 7466 7539 +73
============================================
+ Hits 32279 32568 +289
- Misses 14434 14569 +135
- Partials 3506 3550 +44
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `62.50% <66.66%> (-0.36%)` | :arrow_down: |
| ... and [121 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...74a29bb](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2c78ba) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.02%`.
> The diff coverage is `52.67%`.
> :exclamation: Current head b2c78ba differs from pull request most recent head eb3877a. Consider uploading reports for the commit eb3877a to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.25% -0.03%
- Complexity 314 320 +6
============================================
Files 1169 1177 +8
Lines 50219 50724 +505
Branches 7466 7539 +73
============================================
+ Hits 32279 32592 +313
- Misses 14434 14578 +144
- Partials 3506 3554 +48
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| ... and [130 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...eb3877a](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1aac40) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.01%`.
> The diff coverage is `55.39%`.
> :exclamation: Current head c1aac40 differs from pull request most recent head 667bce6. Consider uploading reports for the commit 667bce6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.25% -0.02%
- Complexity 314 322 +8
============================================
Files 1169 1177 +8
Lines 50219 50687 +468
Branches 7466 7539 +73
============================================
+ Hits 32279 32571 +292
- Misses 14434 14564 +130
- Partials 3506 3552 +46
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `62.50% <66.66%> (-0.36%)` | :arrow_down: |
| ... and [121 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...667bce6](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34fe157) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **increase** coverage by `0.04%`.
> The diff coverage is `54.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
+ Coverage 64.27% 64.31% +0.04%
Complexity 314 314
============================================
Files 1169 1170 +1
Lines 50219 50218 -1
Branches 7466 7448 -18
============================================
+ Hits 32279 32300 +21
+ Misses 14434 14404 -30
- Partials 3506 3514 +8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `54.25% <33.33%> (-3.07%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `41.83% <33.33%> (-0.58%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.42% <44.00%> (-3.51%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <59.09%> (+14.05%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `61.29% <60.00%> (-8.98%)` | :arrow_down: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TransportState.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0U3RhdGUuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...34fe157](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8128636) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.20%`.
> The diff coverage is `52.98%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.06% -0.21%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50638 +419
Branches 7466 7509 +43
============================================
+ Hits 32279 32442 +163
- Misses 14434 14621 +187
- Partials 3506 3575 +69
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.56% <40.90%> (+0.15%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `55.73% <52.50%> (-1.58%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| ... and [130 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...8128636](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (428be69) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.00%`.
> The diff coverage is `55.52%`.
> :exclamation: Current head 428be69 differs from pull request most recent head 667bce6. Consider uploading reports for the commit 667bce6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.26% -0.01%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50680 +461
Branches 7466 7538 +72
============================================
+ Hits 32279 32571 +292
- Misses 14434 14562 +128
- Partials 3506 3547 +41
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `66.66% <80.00%> (+3.80%)` | :arrow_up: |
| ... and [123 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...667bce6](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao commented on a change in pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
guohao commented on a change in pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#discussion_r732452838
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleClientRequestHandler.java
##########
@@ -63,85 +46,29 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)
private void writeRequest(ChannelHandlerContext ctx, final Request req, final ChannelPromise promise) {
DefaultFuture2.addTimeoutListener(req.getId(), ctx::close);
- final RpcInvocation inv = (RpcInvocation) req.getData();
- final URL url = inv.getInvoker().getUrl();
- ConsumerModel consumerModel = inv.getServiceModel() != null ? (ConsumerModel) inv.getServiceModel() : (ConsumerModel) url.getServiceModel();
-
- MethodDescriptor methodDescriptor = getTriMethodDescriptor(consumerModel, inv);
-
- ClassLoadUtil.switchContextLoader(consumerModel.getClassLoader());
- final AbstractClientStream stream = AbstractClientStream.newClientStream(url, methodDescriptor.isUnary());
-
- String ssl = url.getParameter(CommonConstants.SSL_ENABLED_KEY);
- if (StringUtils.isNotEmpty(ssl)) {
- ctx.channel().attr(TripleConstant.SSL_ATTRIBUTE_KEY).set(Boolean.parseBoolean(ssl));
- }
- // Compressor can not be set by dynamic config
- String compressorStr = ConfigurationUtils
- .getCachedDynamicProperty(inv.getModuleModel(), COMPRESSOR_KEY, DEFAULT_COMPRESSOR);
-
- Compressor compressor = Compressor.getCompressor(url.getOrDefaultFrameworkModel(), compressorStr);
- if (compressor != null) {
- stream.setCompressor(compressor);
- }
-
- stream.service(consumerModel)
- .connection(Connection.getConnectionFromChannel(ctx.channel()))
- .method(methodDescriptor)
- .methodName(methodDescriptor.getMethodName())
- .request(req)
- .serialize((String) inv.getObjectAttachment(Constants.SERIALIZATION_KEY))
- .subscribe(new ClientTransportObserver(ctx, stream, promise));
-
- if (methodDescriptor.isUnary()) {
- stream.asStreamObserver().onNext(inv);
- stream.asStreamObserver().onCompleted();
- } else {
- Response response = new Response(req.getId(), req.getVersion());
- AppResponse result;
- // the stream method params is fixed
- if (methodDescriptor.getRpcType() == MethodDescriptor.RpcType.BIDIRECTIONAL_STREAM
- || methodDescriptor.getRpcType() == MethodDescriptor.RpcType.CLIENT_STREAM) {
- StreamObserver<Object> obServer = (StreamObserver<Object>) inv.getArguments()[0];
- obServer = attachCancelContext(obServer, stream.getCancellationContext());
- stream.subscribe(obServer);
- result = new AppResponse(stream.asStreamObserver());
- } else {
- StreamObserver<Object> obServer = (StreamObserver<Object>) inv.getArguments()[1];
- obServer = attachCancelContext(obServer, stream.getCancellationContext());
- stream.subscribe(obServer);
- result = new AppResponse();
- stream.asStreamObserver().onNext(inv.getArguments()[0]);
- stream.asStreamObserver().onCompleted();
- }
- response.setResult(result);
- DefaultFuture2.received(stream.getConnection(), response);
- }
- }
-
- /**
- * Get the tri protocol special MethodDescriptor
- */
- private MethodDescriptor getTriMethodDescriptor(ConsumerModel consumerModel, RpcInvocation inv) {
- List<MethodDescriptor> methodDescriptors = consumerModel.getServiceModel().getMethods(inv.getMethodName());
- if (CollectionUtils.isEmpty(methodDescriptors)) {
- throw new IllegalStateException("methodDescriptors must not be null method=" + inv.getMethodName());
- }
- for (MethodDescriptor methodDescriptor : methodDescriptors) {
- if (Arrays.equals(inv.getParameterTypes(), methodDescriptor.getRealParameterClasses())) {
- return methodDescriptor;
- }
- }
- throw new IllegalStateException("methodDescriptors must not be null method=" + inv.getMethodName());
- }
-
-
- public <T> StreamObserver<T> attachCancelContext(StreamObserver<T> observer, CancellationContext context) {
- if (observer instanceof CancelableStreamObserver) {
- CancelableStreamObserver<T> streamObserver = ((CancelableStreamObserver<T>) observer);
- streamObserver.setCancellationContext(context);
- return streamObserver;
- }
- return observer;
+ Connection connection = Connection.getConnectionFromChannel(ctx.channel());
+ final AbstractClientStream stream = AbstractClientStream.newClientStream(req, connection);
+ final ClientTransportObserver clientTransportObserver = new ClientTransportObserver(ctx, promise);
+ final Http2StreamChannelBootstrap streamChannelBootstrap = new Http2StreamChannelBootstrap(ctx.channel());
+ streamChannelBootstrap.open()
+ .addListener(future -> {
+ if (future.isSuccess()) {
+ final Http2StreamChannel curChannel = (Http2StreamChannel) future.get();
Review comment:
promise.trySuccess
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ClientTransportObserver.java
##########
@@ -20,62 +20,51 @@
import io.netty.buffer.ByteBuf;
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelPromise;
-import io.netty.handler.codec.http.HttpMethod;
import io.netty.handler.codec.http2.DefaultHttp2DataFrame;
import io.netty.handler.codec.http2.DefaultHttp2Headers;
import io.netty.handler.codec.http2.DefaultHttp2HeadersFrame;
import io.netty.handler.codec.http2.DefaultHttp2ResetFrame;
import io.netty.handler.codec.http2.Http2Error;
import io.netty.handler.codec.http2.Http2Headers;
import io.netty.handler.codec.http2.Http2StreamChannel;
-import io.netty.handler.codec.http2.Http2StreamChannelBootstrap;
-import io.netty.util.AsciiString;
public class ClientTransportObserver implements TransportObserver {
- private final AsciiString SCHEME;
private final ChannelHandlerContext ctx;
- private final Http2StreamChannel streamChannel;
private final ChannelPromise promise;
- private boolean headerSent = false;
- private boolean endStreamSent = false;
- private boolean resetSent = false;
+ private Http2StreamChannel streamChannel;
+ private volatile int initialized = DEFAULT;
- public ClientTransportObserver(ChannelHandlerContext ctx, AbstractClientStream stream, ChannelPromise promise) {
- this.ctx = ctx;
- this.promise = promise;
- Boolean ssl = ctx.channel().attr(TripleConstant.SSL_ATTRIBUTE_KEY).get();
- if (ssl != null && ssl) {
- SCHEME = TripleConstant.HTTPS_SCHEME;
- } else {
- SCHEME = TripleConstant.HTTP_SCHEME;
- }
- final Http2StreamChannelBootstrap streamChannelBootstrap = new Http2StreamChannelBootstrap(ctx.channel());
- streamChannel = streamChannelBootstrap.open().syncUninterruptibly().getNow();
+ private static final int DEFAULT = 0;
+ private static final int SUCCESS = 1;
+ private static final int FAIL = 2;
+
+ public void setStreamChannel(Http2StreamChannel streamChannel) {
+ this.streamChannel = streamChannel;
+ initialized = SUCCESS;
+ }
+
+ public void initializedFailed() {
+ initialized = FAIL;
+ }
- final TripleHttp2ClientResponseHandler responseHandler = new TripleHttp2ClientResponseHandler();
- streamChannel.pipeline().addLast(responseHandler)
- .addLast(new GrpcDataDecoder(Integer.MAX_VALUE, true))
- .addLast(new TripleClientInboundHandler());
- streamChannel.attr(TripleConstant.CLIENT_STREAM_KEY).set(stream);
+ public ClientTransportObserver(ChannelHandlerContext ctx, ChannelPromise promise) {
+ this.ctx = ctx;
+ this.promise = promise;
}
@Override
public void onMetadata(Metadata metadata, boolean endStream) {
- if (headerSent) {
- return;
+ while (initialized == DEFAULT) {
+ // wait channel initialized
}
- if (resetSent) {
+ //
Review comment:
Exception or log is need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74a29bb) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.14%`.
> The diff coverage is `55.39%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.13% -0.15%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50687 +468
Branches 7466 7539 +73
============================================
+ Hits 32279 32508 +229
- Misses 14434 14622 +188
- Partials 3506 3557 +51
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `62.50% <66.66%> (-0.36%)` | :arrow_down: |
| ... and [113 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...74a29bb](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34fe157) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **increase** coverage by `0.06%`.
> The diff coverage is `54.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
+ Coverage 64.27% 64.34% +0.06%
Complexity 314 314
============================================
Files 1169 1170 +1
Lines 50219 50253 +34
Branches 7466 7475 +9
============================================
+ Hits 32279 32336 +57
+ Misses 14434 14406 -28
- Partials 3506 3511 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `54.25% <33.33%> (-3.07%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `41.83% <33.33%> (-0.58%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.42% <44.00%> (-3.51%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <59.09%> (+14.05%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `61.29% <60.00%> (-8.98%)` | :arrow_down: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/tri/TransportState.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJhbnNwb3J0U3RhdGUuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...34fe157](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1aac40) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.19%`.
> The diff coverage is `55.39%`.
> :exclamation: Current head c1aac40 differs from pull request most recent head 667bce6. Consider uploading reports for the commit 667bce6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.08% -0.20%
- Complexity 314 320 +6
============================================
Files 1169 1177 +8
Lines 50219 50652 +433
Branches 7466 7512 +46
============================================
+ Hits 32279 32458 +179
- Misses 14434 14619 +185
- Partials 3506 3575 +69
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `62.50% <66.66%> (-0.36%)` | :arrow_down: |
| ... and [136 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...667bce6](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1aac40) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.16%`.
> The diff coverage is `55.39%`.
> :exclamation: Current head c1aac40 differs from pull request most recent head 667bce6. Consider uploading reports for the commit 667bce6 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.11% -0.17%
- Complexity 314 321 +7
============================================
Files 1169 1177 +8
Lines 50219 50687 +468
Branches 7466 7539 +73
============================================
+ Hits 32279 32498 +219
- Misses 14434 14621 +187
- Partials 3506 3568 +62
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.85% <43.47%> (+0.44%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `58.22% <58.16%> (+0.91%)` | :arrow_up: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `62.50% <66.66%> (-0.36%)` | :arrow_down: |
| ... and [119 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...667bce6](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd122ea) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.03%`.
> The diff coverage is `52.37%`.
> :exclamation: Current head bd122ea differs from pull request most recent head b2c78ba. Consider uploading reports for the commit b2c78ba to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.23% -0.04%
- Complexity 314 320 +6
============================================
Files 1169 1178 +9
Lines 50219 50726 +507
Branches 7466 7539 +73
============================================
+ Hits 32279 32586 +307
- Misses 14434 14583 +149
- Partials 3506 3557 +51
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| ... and [128 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...b2c78ba](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2c78ba) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.04%`.
> The diff coverage is `52.67%`.
> :exclamation: Current head b2c78ba differs from pull request most recent head eb3877a. Consider uploading reports for the commit eb3877a to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.23% -0.05%
- Complexity 314 320 +6
============================================
Files 1169 1177 +8
Lines 50219 50724 +505
Branches 7466 7539 +73
============================================
+ Hits 32279 32582 +303
- Misses 14434 14585 +151
- Partials 3506 3557 +51
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| ... and [129 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...eb3877a](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c21d09a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.23%`.
> The diff coverage is `52.24%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.04% -0.24%
- Complexity 314 320 +6
============================================
Files 1169 1177 +8
Lines 50219 50742 +523
Branches 7466 7528 +62
============================================
+ Hits 32279 32498 +219
- Misses 14434 14665 +231
- Partials 3506 3579 +73
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/dubbo/rpc/model/MethodDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTWV0aG9kRGVzY3JpcHRvci5qYXZh) | `76.12% <0.00%> (-7.97%)` | :arrow_down: |
| [...che/dubbo/rpc/protocol/tri/IdentityCompressor.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvSWRlbnRpdHlDb21wcmVzc29yLmphdmE=) | `100.00% <ø> (ø)` | |
| [...java/org/apache/dubbo/rpc/protocol/tri/Stream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU3RyZWFtLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `34.21% <14.58%> (-2.44%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `30.95% <22.22%> (-8.53%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `43.58% <40.90%> (+1.18%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlVXRpbC5qYXZh) | `53.50% <50.00%> (+5.38%)` | :arrow_up: |
| ... and [143 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...c21d09a](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9057: [3.0-Triple] Refactor transport state and other code
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9057:
URL: https://github.com/apache/dubbo/pull/9057#issuecomment-945427813
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9057](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8128636) into [3.0](https://codecov.io/gh/apache/dubbo/commit/33af482ce223999ebcc4cec0c04300767168829e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33af482) will **decrease** coverage by `0.17%`.
> The diff coverage is `52.98%`.
[](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9057 +/- ##
============================================
- Coverage 64.27% 64.10% -0.18%
- Complexity 314 323 +9
============================================
Files 1169 1177 +8
Lines 50219 50673 +454
Branches 7466 7536 +70
============================================
+ Hits 32279 32483 +204
- Misses 14434 14622 +188
- Partials 3506 3568 +62
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pc/protocol/tri/TripleHttp2FrameServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSHR0cDJGcmFtZVNlcnZlckhhbmRsZXIuamF2YQ==) | `37.20% <0.00%> (+0.56%)` | :arrow_up: |
| [.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvR3JwY1N0YXR1cy5qYXZh) | `37.89% <14.28%> (-3.78%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2VydmVyU3RyZWFtLmphdmE=) | `32.18% <28.57%> (-7.29%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlDbGllbnRTdHJlYW0uamF2YQ==) | `30.76% <35.71%> (-8.30%)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/tri/AbstractStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTdHJlYW0uamF2YQ==) | `42.56% <40.90%> (+0.15%)` | :arrow_up: |
| [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `51.63% <50.00%> (-2.29%)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/tri/AbstractClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RDbGllbnRTdHJlYW0uamF2YQ==) | `55.73% <52.50%> (-1.58%)` | :arrow_down: |
| [...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50U3RyZWFtLmphdmE=) | `58.33% <56.09%> (-11.94%)` | :arrow_down: |
| [...ache/dubbo/rpc/protocol/tri/UnaryServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVW5hcnlTZXJ2ZXJTdHJlYW0uamF2YQ==) | `60.00% <60.86%> (+14.05%)` | :arrow_up: |
| [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `70.96% <78.57%> (+8.11%)` | :arrow_up: |
| ... and [112 more](https://codecov.io/gh/apache/dubbo/pull/9057/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33af482...8128636](https://codecov.io/gh/apache/dubbo/pull/9057?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org