You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@wandisco.com> on 2014/04/09 17:51:37 UTC
remote-only-status branch ready for review
I've finished the work on the remote-only-status branch. I'd like to ask
for a review of the changes before I merge it to trunk. I'm currently
running a full round of tests on the branch, which I've sync'd with
trunk up to r1585988; results are looking good for now.
If the tests pass, and there are no objections, I'll merge to trunk
early next week.
svn diff ^/subversion/trunk ^/subversion/branches/remote-only-status
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com
Re: remote-only-status branch ready for review
Posted by Branko Čibej <br...@wandisco.com>.
On 09.04.2014 12:18, Bert Huijben wrote:
>
>> -----Original Message-----
>> From: Ben Reser [mailto:ben@reser.org]
>> Sent: woensdag 9 april 2014 20:07
>> To: Branko Čibej; Subversion Development
>> Subject: Re: remote-only-status branch ready for review
>>
>> On 4/9/14, 9:51 AM, Branko Čibej wrote:
>>> I've finished the work on the remote-only-status branch. I'd like to ask
>>> for a review of the changes before I merge it to trunk. I'm currently
>>> running a full round of tests on the branch, which I've sync'd with
>>> trunk up to r1585988; results are looking good for now.
>>>
>>> If the tests pass, and there are no objections, I'll merge to trunk
>>> early next week.
>>>
>>> svn diff ^/subversion/trunk ^/subversion/branches/remote-only-status
>> Looks good to me. I noticed the whitespace things that Bert mentioned on
>> IRC.
>> Not going to point them out since you seem to already be aware of them.
> +1
> I agree... Looks good.
>
> Personally I don't see remaining reasons that would require to wait until next week, but that is your call.
Happy to do it sooner rather than later. r1586146.
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com
RE: remote-only-status branch ready for review
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Ben Reser [mailto:ben@reser.org]
> Sent: woensdag 9 april 2014 20:07
> To: Branko Čibej; Subversion Development
> Subject: Re: remote-only-status branch ready for review
>
> On 4/9/14, 9:51 AM, Branko Čibej wrote:
> > I've finished the work on the remote-only-status branch. I'd like to ask
> > for a review of the changes before I merge it to trunk. I'm currently
> > running a full round of tests on the branch, which I've sync'd with
> > trunk up to r1585988; results are looking good for now.
> >
> > If the tests pass, and there are no objections, I'll merge to trunk
> > early next week.
> >
> > svn diff ^/subversion/trunk ^/subversion/branches/remote-only-status
>
> Looks good to me. I noticed the whitespace things that Bert mentioned on
> IRC.
> Not going to point them out since you seem to already be aware of them.
+1
I agree... Looks good.
Personally I don't see remaining reasons that would require to wait until next week, but that is your call.
If there are remaining issues they are small enough to handle them on trunk.
(And the resulting total branch-patch looks small enough to review in the final commit for others)
Bert
Re: remote-only-status branch ready for review
Posted by Ben Reser <be...@reser.org>.
On 4/9/14, 9:51 AM, Branko Čibej wrote:
> I've finished the work on the remote-only-status branch. I'd like to ask
> for a review of the changes before I merge it to trunk. I'm currently
> running a full round of tests on the branch, which I've sync'd with
> trunk up to r1585988; results are looking good for now.
>
> If the tests pass, and there are no objections, I'll merge to trunk
> early next week.
>
> svn diff ^/subversion/trunk ^/subversion/branches/remote-only-status
Looks good to me. I noticed the whitespace things that Bert mentioned on IRC.
Not going to point them out since you seem to already be aware of them.