You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Qinkun Bao <no...@github.com.INVALID> on 2022/02/03 08:46:10 UTC

[apache/incubator-teaclave] update WAMR (PR #608)

## Description

1. Update WAMR dependencies.
2. Remove assert and unwrap.

## Type of change (select or add applied and delete the others)

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates

## How has this been tested?

## Checklist

- [x] Fork the repo and create your branch from `master`.
- [x] If you&#39;ve added code that should be tested, add tests.
- [x] If you&#39;ve changed APIs, update the documentation.
- [x] Ensure the tests pass (see CI results).
- [x] Make sure your code lints/format.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/608

-- Commit Summary --

  * update WAMR

-- File Changes --

    M executor/src/wamr.rs (56)
    M third_party/wasm-micro-runtime (2)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/608.patch
https://github.com/apache/incubator-teaclave/pull/608.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/608
You are receiving this because you are subscribed to this thread.

Message ID: &lt;apache/incubator-teaclave/pull/608@github.com&gt;

Re: [apache/incubator-teaclave] update WAMR (PR #608)

Posted by Mingshen Sun <no...@github.com.INVALID>.
This PR becomes stale. Closing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/608#issuecomment-1051250737
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/incubator-teaclave] update WAMR (PR #608)

Posted by Qinkun Bao <no...@github.com.INVALID>.
> I suggest to wrap C APIs into a struct and use `new` and `drop` for resource management.

Sounds good! Will do.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/608#issuecomment-1029456173
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/incubator-teaclave] update WAMR (PR #608)

Posted by Mingshen Sun <no...@github.com.INVALID>.
I suggest to wrap C APIs into a struct and use `new` and `drop` for resource management.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/608#issuecomment-1029454074
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/incubator-teaclave] update WAMR (PR #608)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Closed #608.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/608#event-6141846606
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>