You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-dev@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/07/12 02:13:35 UTC

[jira] [Resolved] (HDFS-3639) JspHelper#getUGI should always verify the token if security is enabled

     [ https://issues.apache.org/jira/browse/HDFS-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins resolved HDFS-3639.
-------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.1-alpha
                      1.2.0
    Target Version/s:   (was: 1.2.0, 2.0.1-alpha)
        Hadoop Flags: Reviewed

Thanks for the review Daryn. I've committed this and merged to branch-2 and branch-1. 
                
> JspHelper#getUGI should always verify the token if security is enabled
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3639
>                 URL: https://issues.apache.org/jira/browse/HDFS-3639
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 1.2.0, 2.0.1-alpha
>
>         Attachments: hdfs-3639-b1.txt, hdfs-3639.txt
>
>
> JspHelper#getUGI on verifies the given token if the context and nn are set (added in HDFS-2416). We should unconditionally verifyToken the token, ie a bug where "name.node" is not set in the context object should not result in not verifying the token. In practice this shouldn't be an issue as per HDFS-3434 the context and NN should never be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira