You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Gary Dusbabek (JIRA)" <ji...@apache.org> on 2011/01/07 17:57:45 UTC
[jira] Created: (CASSANDRA-1951) offline local nodes
offline local nodes
-------------------
Key: CASSANDRA-1951
URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Gary Dusbabek
Priority: Minor
Fix For: 0.8
We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1951) offline local nodes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978863#action_12978863 ]
Jonathan Ellis commented on CASSANDRA-1951:
-------------------------------------------
What part does 1108 not do for us?
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Priority: Minor
> Fix For: 0.8
>
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1951) offline local nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985834#action_12985834 ]
Sylvain Lebresne commented on CASSANDRA-1951:
---------------------------------------------
No it doesn't. But it wouldn't be too hard to not launch thrift (that can even
be separate of #526, that is you can join the ring without launching thrift
and vice-versa).
I'll give it a shot and will try to add what's needed for this issue as well.
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Priority: Minor
> Fix For: 0.8
>
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1951) offline local nodes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1951:
--------------------------------------
Fix Version/s: (was: 0.7.1)
0.7.2
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.7.2
>
> Attachments: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1951) offline local nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1951:
----------------------------------------
Attachment: 0002-Remove-thread-creation-of-EmbeddedCassandraService.patch
0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch
With the first patch there is a race condition in the unit test, in the CliTest in particular (it cannot connect). This is due to the tests using EmbeddedCassandraService. Basically the way EmbeddedCassandraService was written interacted badly with the fact that the CassandraDaemon launch its own thread and the tests were trying to connect before the server was properly launched.
Attaching a second patch that simplify EmbeddedCassandraService now that CassandraDeamon.start() is non-blocking and make the tests pass. I've also rebased the first patch
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.7.2
>
> Attachments: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch, 0002-Remove-thread-creation-of-EmbeddedCassandraService.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1951) offline local nodes
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Dusbabek updated CASSANDRA-1951:
-------------------------------------
Reviewer: gdusbabek
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.7.1
>
> Attachments: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1951) offline local nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1951:
----------------------------------------
Attachment: (was: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch)
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.7.2
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1951) offline local nodes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987082#action_12987082 ]
Hudson commented on CASSANDRA-1951:
-----------------------------------
Integrated in Cassandra #691 (See [https://hudson.apache.org/hudson/job/Cassandra/691/])
merge from 0.7 (CASSANDRA-1951)
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.7.2
>
> Attachments: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch, 0002-Remove-thread-creation-of-EmbeddedCassandraService.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1951) offline local nodes
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978865#action_12978865 ]
Gary Dusbabek commented on CASSANDRA-1951:
------------------------------------------
The node will still accept thrift requests (unless I read the patch wrong).
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Priority: Minor
> Fix For: 0.8
>
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1951) offline local nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1951:
----------------------------------------
Attachment: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch
Attached patch does the missing part, that is it allows to stop and restart the thrift server (or avro, though I've tested the latter less extensively) from JMX. In addition, it allows to not start the thrift server at boot time through -Dcassandra.start_rpc=false (in which case it can be start through JMX).
Implementation note: the thrift server (connection accepting code) was running as the main thread (serverEngine.server() was blocking) which didn't make this easily doable so the patch change this and spawn a thread for the said connection acception code (Avro was already doing this in a separate thread).
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.7.1
>
> Attachments: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch
>
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1951) offline local nodes
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986434#action_12986434 ]
Gary Dusbabek commented on CASSANDRA-1951:
------------------------------------------
As far as starting, stopping and restarting the thrift server, the code looks good. However, during testing I noticed that stray RowMutations make their way from other nodes (about one per minute in my case) and get applied on the node after I have already stopped thrift and gossip. This makes me think something is incorrect in our "is-this-node-online" code.
I'm fine with pushing this off to 0.7.2 if there are other priorities that need to be focused on.
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.7.1
>
> Attachments: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1951) offline local nodes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987060#action_12987060 ]
Hudson commented on CASSANDRA-1951:
-----------------------------------
Integrated in Cassandra-0.7 #216 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/216/])
turn thrift ports off. patch by Sylvain Lebresne, reviewed by gdusbabek. CASSANDRA-1951
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.7.2
>
> Attachments: 0001-Allow-to-start-and-stop-the-thrift-server-through-JM.patch, 0002-Remove-thread-creation-of-EmbeddedCassandraService.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1951) offline local nodes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985815#action_12985815 ]
Jonathan Ellis commented on CASSANDRA-1951:
-------------------------------------------
does CASSANDRA-526 get you the rest of the way there?
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Priority: Minor
> Fix For: 0.8
>
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1951) offline local nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne reassigned CASSANDRA-1951:
-------------------------------------------
Assignee: Sylvain Lebresne
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.8
>
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1951) offline local nodes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985816#action_12985816 ]
Jonathan Ellis commented on CASSANDRA-1951:
-------------------------------------------
... actually I think 526 doesn't affect Thrift either.
> offline local nodes
> -------------------
>
> Key: CASSANDRA-1951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1951
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Priority: Minor
> Fix For: 0.8
>
>
> We'd like the ability to take a node offline (gossip, thrift, etc), but without bringing down cassandra. The main reason is so that compactions can be performed completely off-line.
> CASSANDRA-1108 gets us most of the way there, but not all the way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.