You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Gerolf Seitz <ge...@gmail.com> on 2007/07/01 08:58:07 UTC

Re: [vote] rebuild of wicket-1.3.0-beta 2

i found some naming inconsistencies:
JavaScriptReference vs. JavascriptResourceReference
there are some other Java(S/s)cript classes...

gerolf

On 6/30/07, jweekend <jw...@cabouge.com> wrote:
>
>
> FYI, I successfully downloaded the 1.3.0 beta2 release from
> http://www.apache.org/dist/wicket/1.3.0-beta2/ .
> We're putting a course together, based on 1.3 so hopefully the APIs are
> fairly stable now. Having said that, if there is stuff that no longer
> makes
> any sense (unhelpful naming, bad signatures ...), IMO, this is probably
> the
> last chance to change it without causing a riot, so I'd say it's better
> now
> than never.
> Cemal
>
>
>
> Martijn Dashorst wrote:
> >
> > The build now includes guice and ioc, and the release notes (list of
> > fixed JIRA issues)
> >
> > [ ] I have checked the distribution and +1 its release
> > [ ] I haven't checked the distribution and +0 its release
> > [ ] I have checked the distribution and -1 its release because...
> >
> > I will try to upload this to the mirroring site once we have enough
> > +1's (3 minimal), if we have enough karma to do so. Otherwise, we'll
> > just have to do without 2000+ downloads.
> >
> > Martijn
> >
> > --
> > Wicket joins the Apache Software Foundation as Apache Wicket
> > Join the wicket community at irc.freenode.net: ##wicket
> > Wicket 1.2.6 contains a very important fix. Download Wicket now!
> > http://wicketframework.org
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/-vote--rebuild-of-wicket-1.3.0-beta-2-tf3996683.html#a11369135
> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>
>

Re: [vote] rebuild of wicket-1.3.0-beta 2

Posted by Gerolf Seitz <ge...@gmail.com>.
filed a jira issue at https://issues.apache.org/jira/browse/WICKET-715

On 7/3/07, Johan Compagner <jc...@gmail.com> wrote:
>
> then just see if we do it for the next version.
>
> On 7/2/07, Eelco Hillenius <ee...@gmail.com> wrote:
> >
> > > Changing the case of Java files tends to cause pain on Windows
> systems,
> > > because they're case-insensitive. We're almost guaranteed to have
> people
> > > with strange ClassNotFoundExceptions if we go and do this.
> > >
> > > It's yet another API change just before we release 1.3.0.
> > >
> > > If we fix the class names, we should also fix the method names.
> There's
> > > a lot of inconsistency at the moment, and this would cause an awful
> lot
> > > of API breakage.
> > >
> > > It would make sense to use "Javascript" everywhere, as "JavaScript" is
> > > one word, so when you CamelCase it, it should all go lower.
> > >
> > > Otherwise, if you have a "JavaScriptHandler", is it a ScriptHandler
> for
> > > Java, or a Handler for JavaScript?
> > >
> > > Anyway, there's a bunch of stuff we'd need to fix, including
> > > HeaderContributor.forJavaScript(), etc. etc.
> > >
> > > I don't think we want to do that this close to a 1.3 release. I
> imagine
> > > it'd be a faff for the upcoming Wicket book, too.
> >
> > I agree. The book isn't much of a problem in this case, but I know
> > from some previous renames (around 1.1 if I recall correctly) that it
> > can be a pain especially for Windows users. Annoying as these little
> > naming inconsistencies can be, I'm not sure if it's is worth the pain.
> >
> > Eelco
> >
>

Re: [vote] rebuild of wicket-1.3.0-beta 2

Posted by Johan Compagner <jc...@gmail.com>.
then just see if we do it for the next version.

On 7/2/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> > Changing the case of Java files tends to cause pain on Windows systems,
> > because they're case-insensitive. We're almost guaranteed to have people
> > with strange ClassNotFoundExceptions if we go and do this.
> >
> > It's yet another API change just before we release 1.3.0.
> >
> > If we fix the class names, we should also fix the method names. There's
> > a lot of inconsistency at the moment, and this would cause an awful lot
> > of API breakage.
> >
> > It would make sense to use "Javascript" everywhere, as "JavaScript" is
> > one word, so when you CamelCase it, it should all go lower.
> >
> > Otherwise, if you have a "JavaScriptHandler", is it a ScriptHandler for
> > Java, or a Handler for JavaScript?
> >
> > Anyway, there's a bunch of stuff we'd need to fix, including
> > HeaderContributor.forJavaScript(), etc. etc.
> >
> > I don't think we want to do that this close to a 1.3 release. I imagine
> > it'd be a faff for the upcoming Wicket book, too.
>
> I agree. The book isn't much of a problem in this case, but I know
> from some previous renames (around 1.1 if I recall correctly) that it
> can be a pain especially for Windows users. Annoying as these little
> naming inconsistencies can be, I'm not sure if it's is worth the pain.
>
> Eelco
>

Re: [vote] rebuild of wicket-1.3.0-beta 2

Posted by Eelco Hillenius <ee...@gmail.com>.
> Changing the case of Java files tends to cause pain on Windows systems,
> because they're case-insensitive. We're almost guaranteed to have people
> with strange ClassNotFoundExceptions if we go and do this.
>
> It's yet another API change just before we release 1.3.0.
>
> If we fix the class names, we should also fix the method names. There's
> a lot of inconsistency at the moment, and this would cause an awful lot
> of API breakage.
>
> It would make sense to use "Javascript" everywhere, as "JavaScript" is
> one word, so when you CamelCase it, it should all go lower.
>
> Otherwise, if you have a "JavaScriptHandler", is it a ScriptHandler for
> Java, or a Handler for JavaScript?
>
> Anyway, there's a bunch of stuff we'd need to fix, including
> HeaderContributor.forJavaScript(), etc. etc.
>
> I don't think we want to do that this close to a 1.3 release. I imagine
> it'd be a faff for the upcoming Wicket book, too.

I agree. The book isn't much of a problem in this case, but I know
from some previous renames (around 1.1 if I recall correctly) that it
can be a pain especially for Windows users. Annoying as these little
naming inconsistencies can be, I'm not sure if it's is worth the pain.

Eelco

Re: [vote] rebuild of wicket-1.3.0-beta 2

Posted by Al Maw <wi...@almaw.com>.
> On 7/1/07, Gerolf Seitz <ge...@gmail.com> wrote:
>>
>> i found some naming inconsistencies:
>> JavaScriptReference vs. JavascriptResourceReference
>> there are some other Java(S/s)cript classes...

Johan Compagner wrote:
> please send in a patch so that we can have the right names before the
> final of 1.3

Changing the case of Java files tends to cause pain on Windows systems, 
because they're case-insensitive. We're almost guaranteed to have people 
with strange ClassNotFoundExceptions if we go and do this.

It's yet another API change just before we release 1.3.0.

If we fix the class names, we should also fix the method names. There's 
a lot of inconsistency at the moment, and this would cause an awful lot 
of API breakage.

It would make sense to use "Javascript" everywhere, as "JavaScript" is 
one word, so when you CamelCase it, it should all go lower.

Otherwise, if you have a "JavaScriptHandler", is it a ScriptHandler for 
Java, or a Handler for JavaScript?

Anyway, there's a bunch of stuff we'd need to fix, including 
HeaderContributor.forJavaScript(), etc. etc.

I don't think we want to do that this close to a 1.3 release. I imagine 
it'd be a faff for the upcoming Wicket book, too.

Best regards,

Al
-- 
Alastair Maw
Wicket-biased blog at http://herebebeasties.com

Re: [vote] rebuild of wicket-1.3.0-beta 2

Posted by Johan Compagner <jc...@gmail.com>.
please send in a patch so that we can have the right names before the final
of 1.3

On 7/1/07, Gerolf Seitz <ge...@gmail.com> wrote:
>
> i found some naming inconsistencies:
> JavaScriptReference vs. JavascriptResourceReference
> there are some other Java(S/s)cript classes...
>
> gerolf
>
> On 6/30/07, jweekend <jw...@cabouge.com> wrote:
> >
> >
> > FYI, I successfully downloaded the 1.3.0 beta2 release from
> > http://www.apache.org/dist/wicket/1.3.0-beta2/ .
> > We're putting a course together, based on 1.3 so hopefully the APIs are
> > fairly stable now. Having said that, if there is stuff that no longer
> > makes
> > any sense (unhelpful naming, bad signatures ...), IMO, this is probably
> > the
> > last chance to change it without causing a riot, so I'd say it's better
> > now
> > than never.
> > Cemal
> >
> >
> >
> > Martijn Dashorst wrote:
> > >
> > > The build now includes guice and ioc, and the release notes (list of
> > > fixed JIRA issues)
> > >
> > > [ ] I have checked the distribution and +1 its release
> > > [ ] I haven't checked the distribution and +0 its release
> > > [ ] I have checked the distribution and -1 its release because...
> > >
> > > I will try to upload this to the mirroring site once we have enough
> > > +1's (3 minimal), if we have enough karma to do so. Otherwise, we'll
> > > just have to do without 2000+ downloads.
> > >
> > > Martijn
> > >
> > > --
> > > Wicket joins the Apache Software Foundation as Apache Wicket
> > > Join the wicket community at irc.freenode.net: ##wicket
> > > Wicket 1.2.6 contains a very important fix. Download Wicket now!
> > > http://wicketframework.org
> > >
> > >
> >
> > --
> > View this message in context:
> >
> http://www.nabble.com/-vote--rebuild-of-wicket-1.3.0-beta-2-tf3996683.html#a11369135
> > Sent from the Wicket - Dev mailing list archive at Nabble.com.
> >
> >
>