You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/26 13:04:58 UTC
[GitHub] [kafka] jlprat opened a new pull request #10767: MINOR: Fix code listings in quickstart
jlprat opened a new pull request #10767:
URL: https://github.com/apache/kafka/pull/10767
Uses the right character for shell scripts (`>` instead of `$`)
Uses the right syntax highlighting
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10767: MINOR: Fix code listings in quickstart.html
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10767:
URL: https://github.com/apache/kafka/pull/10767#issuecomment-848762425
CC. @cadonna as you reviewed the last doc changes on formatting and styling, you might want to review these as well. I split the changes in several PRs so it's more bearable to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10767: MINOR: Fix code listings in quickstart.html
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10767:
URL: https://github.com/apache/kafka/pull/10767#discussion_r640262291
##########
File path: docs/quickstart.html
##########
@@ -244,7 +244,7 @@ <h4 class="anchor-heading">
<a href="#quickstart_kafkacongrats">Congratulations!</a>
</h4>
- <p>You have successfully finished the Apache Kafka quickstart.<div>
+ <p>You have successfully finished the Apache Kafka quickstart.
Review comment:
Nice fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10767: MINOR: Fix code listings in quickstart.html
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10767:
URL: https://github.com/apache/kafka/pull/10767#issuecomment-849379890
@showuon thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10767: MINOR: Fix code listings in quickstart.html
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10767:
URL: https://github.com/apache/kafka/pull/10767#issuecomment-849363018
Hi @showuon it is not the right character _per se_, it is only for a consistency reason with the rest of the examples on the documentation. The vast majority of the bash examples used `>` (and only a few used `$`), so I unified the examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org