[jira] [Comment Edited] (BIGTOP-1973) Add new tests for HDFS Balancer functionality

["YoungWoo Kim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706261#comment-14706261 ] 

YoungWoo Kim edited comment on BIGTOP-1973 at 8/21/15 5:51 AM:
---------------------------------------------------------------

Thanks [~kollavenkat], Looks good to me and new tests work fine for me!

After all, static member 'thresh' will never be used, right? so it would be perfect if related lines are removed!
{code}
...

  private static String thresh = "10";

  @BeforeClass
  public static void setUp() {

    // unpack resource
    JarContent.unpackJarContainer(TestHDFSBalancer.class, ".", null);
    if (System.getProperty("threshold") != null) {
      thresh = System.getProperty("threshold");
    }
  }

...
{code}



was (Author: warwithin):
Thanks [~kollavenkat], Looks good to me and new tests works fine for me!

One thing to note: After all, static member 'thresh' will never be used, right? so it would be perfect if related lines are removed!
{code}
...

  private static String thresh = "10";

  @BeforeClass
  public static void setUp() {

    // unpack resource
    JarContent.unpackJarContainer(TestHDFSBalancer.class, ".", null);
    if (System.getProperty("threshold") != null) {
      thresh = System.getProperty("threshold");
    }
  }

...
{code}


> Add new tests for HDFS Balancer functionality
> ---------------------------------------------
>
>                 Key: BIGTOP-1973
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1973
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: tests
>            Reporter: Venkata Srinivasa Rao Kolla 
>            Priority: Minor
>         Attachments: BIGTOP-1973.patch
>
>
> Add below tests related to HDFS admin module to the existing test class file TestHDFSBalancer.groovy:
>     - test threshold with negative value.
>     - test threshold with zero value.
>     - test threshold with max value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)