You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Íñigo Goiri (JIRA)" <ji...@apache.org> on 2019/02/18 23:32:00 UTC

[jira] [Commented] (HDFS-9596) Remove Shuffle Method From DFSUtil

    [ https://issues.apache.org/jira/browse/HDFS-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771433#comment-16771433 ] 

Íñigo Goiri commented on HDFS-9596:
-----------------------------------

Thanks [~belugabehr] for the patch.
Committed to trunk.

> Remove Shuffle Method From DFSUtil
> ----------------------------------
>
>                 Key: HDFS-9596
>                 URL: https://issues.apache.org/jira/browse/HDFS-9596
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>             Fix For: 3.3.0
>
>         Attachments: HDFS-9596.2.patch, HDFS-9596.3.patch, HDFS-9596.4.patch, HDFS-9596.5.patch, HDFS-9596.6.patch, HDFS-9596.7.patch, Shuffle.HDFS-9596.patch
>
>
> DFSUtil contains a "shuffle" routine that shuffles arrays.  With a little wrapping, Java Collections class can shuffle.  This code is superfluous and undocumented.  The method returns an array, though it does not specify if it returns the same array or a new, copy, array of shuffled items.
> It is only used in one place, so it is better to simply remove and substitute this implementation with the java Collections implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org