You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/26 05:12:56 UTC
[GitHub] [hive] ujc714 opened a new pull request #2319: HIVE-25158: Beeline/hive command can't get operation logs when hive.s…
ujc714 opened a new pull request #2319:
URL: https://github.com/apache/hive/pull/2319
### What changes were proposed in this pull request?
Changed one line in service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java. The session log directory should be <operationLogRootDir>/<session_id>/ instead of <operationLogRootDir>/<sessionHandle_id>/.
### Why are the changes needed?
If we run beeline/hive command with parameter "--hiveconf hive.session.id=xxx", we can't see the query operation logs. And the operation logs can't be cleaned up by HS2.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added testSessionId1() and testSessionId2() in TestHiveCli.java.
Run "mvn test -Dtest=org.apache.hive.beeline.cli.TestHiveCli"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2319: HIVE-25158: Beeline/hive command can't get operation logs when hive.s…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2319:
URL: https://github.com/apache/hive/pull/2319#issuecomment-974730573
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on a change in pull request #2319: HIVE-25158: Beeline/hive command can't get operation logs when hive.s…
Posted by GitBox <gi...@apache.org>.
abstractdog commented on a change in pull request #2319:
URL: https://github.com/apache/hive/pull/2319#discussion_r674814465
##########
File path: jdbc/src/java/org/apache/hive/jdbc/Utils.java
##########
@@ -438,6 +438,18 @@ public static JdbcConnectionParams extractURLComponents(String uri, Properties i
// Don't parse them, but set embedded mode as true
if (uri.equalsIgnoreCase(URL_PREFIX)) {
connParams.setEmbeddedMode(true);
+ for (Map.Entry<Object, Object> kv : info.entrySet()) {
Review comment:
how is this code part related to the original intention of the patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on a change in pull request #2319: HIVE-25158: Beeline/hive command can't get operation logs when hive.s…
Posted by GitBox <gi...@apache.org>.
abstractdog commented on a change in pull request #2319:
URL: https://github.com/apache/hive/pull/2319#discussion_r674823717
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -353,7 +353,11 @@ protected HiveConnection(String uri, Properties info,
}
if (isEmbeddedMode) {
client = EmbeddedCLIServicePortal.get(connParams.getHiveConfs());
+ String sessionId = connParams.getHiveConfs().get(HiveConf.ConfVars.HIVESESSIONID.varname);
Review comment:
this part seems to be hacky, original code made a client from the confs then cleared the conf, now we're forcing the sessionId to be present in the hive confs after clearing, why is it?
this way we'll have an almost empty connParams.getHiveConfs(), having only session id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2319: HIVE-25158: Beeline/hive command can't get operation logs when hive.s…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2319:
URL: https://github.com/apache/hive/pull/2319#issuecomment-974730573
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2319: HIVE-25158: Beeline/hive command can't get operation logs when hive.s…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2319:
URL: https://github.com/apache/hive/pull/2319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on a change in pull request #2319: HIVE-25158: Beeline/hive command can't get operation logs when hive.s…
Posted by GitBox <gi...@apache.org>.
abstractdog commented on a change in pull request #2319:
URL: https://github.com/apache/hive/pull/2319#discussion_r674814465
##########
File path: jdbc/src/java/org/apache/hive/jdbc/Utils.java
##########
@@ -438,6 +438,18 @@ public static JdbcConnectionParams extractURLComponents(String uri, Properties i
// Don't parse them, but set embedded mode as true
if (uri.equalsIgnoreCase(URL_PREFIX)) {
connParams.setEmbeddedMode(true);
+ for (Map.Entry<Object, Object> kv : info.entrySet()) {
Review comment:
how is this code part related to the original patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org